From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Benson Leung <bleung@google.com>,
Jarkko Nikula <jarkko.nikula@intel.com>
Subject: Re: [PATCHv2 3/5] ASoC: Intel: Add Intel SST audio DSP Firmware loader.
Date: Mon, 17 Feb 2014 16:49:27 +0000 [thread overview]
Message-ID: <1392655767.2390.23.camel@loki> (raw)
In-Reply-To: <s5ha9dpzw72.wl%tiwai@suse.de>
On Mon, 2014-02-17 at 14:48 +0100, Takashi Iwai wrote:
> At Mon, 17 Feb 2014 13:32:08 +0000,
> Liam Girdwood wrote:
> > + /* allocate DMA buffer to store FW data */
> > + sst_fw->dma_buf = dma_alloc_coherent(dsp->dev, sst_fw->size,
> > + &sst_fw->dmable_fw_paddr, GFP_DMA);
>
> Missing GFP_KERNEL?
>
>
Yep thanks, I'll fix it incrementally if it's OK with Mark ?
Liam
next prev parent reply other threads:[~2014-02-17 16:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 13:32 [PATCHv2 1/5] ASoC: Intel: Add Intel SST audio DSP low level shim driver Liam Girdwood
2014-02-17 13:32 ` [PATCHv2 2/5] ASoC: Intel: Add common SST driver loader on ACPI systems Liam Girdwood
2014-02-17 13:32 ` [PATCHv2 3/5] ASoC: Intel: Add Intel SST audio DSP Firmware loader Liam Girdwood
2014-02-17 13:48 ` Takashi Iwai
2014-02-17 16:49 ` Liam Girdwood [this message]
2014-02-18 1:44 ` Mark Brown
2014-02-18 1:35 ` Mark Brown
2014-02-18 8:47 ` Liam Girdwood
2014-02-17 13:32 ` [PATCHv2 4/5] ASoC: Intel: Add trace support for generic SST IPC messages Liam Girdwood
2014-02-18 1:36 ` Mark Brown
2014-02-18 8:52 ` Liam Girdwood
2014-02-18 9:34 ` Takashi Iwai
2014-02-17 13:32 ` [PATCHv2 5/5] ASoC: Intel: Add build support for Intel SST DSP core Liam Girdwood
2014-02-17 17:33 ` [PATCHv2 1/5] ASoC: Intel: Add Intel SST audio DSP low level shim driver Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392655767.2390.23.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@google.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox