Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Intel: Fix sparse warnings for firmware loader.
Date: Wed, 19 Feb 2014 11:10:30 +0000	[thread overview]
Message-ID: <1392808230.2351.43.camel@loki> (raw)
In-Reply-To: <1392808000.2351.40.camel@loki>

On Wed, 2014-02-19 at 11:06 +0000, Liam Girdwood wrote:
> On Wed, 2014-02-19 at 11:00 +0000, Liam Girdwood wrote:
> > Sparse gives us the following warning on sst-firmware.c
> > 
> >   CHECK   sound/soc/intel/sst-firmware.c
> > sound/soc/intel/sst-firmware.c:39:34: warning: incorrect type in argument 1 (different address spaces)
> > sound/soc/intel/sst-firmware.c:39:34:    expected void volatile [noderef] <asn:2>*dst
> > sound/soc/intel/sst-firmware.c:39:34:    got void *
> > sound/soc/intel/sst-firmware.c:417:36: warning: incorrect type in argument 1 (different address spaces)
> > sound/soc/intel/sst-firmware.c:417:36:    expected void *dest
> > sound/soc/intel/sst-firmware.c:417:36:    got void [noderef] <asn:2>*
> > sound/soc/intel/sst-firmware.c:430:5: warning: symbol 'sst_block_module_remove' was not declared. Should it be static?
> > 
> 
> Btw, the last warning appears to be a false positive as
> sst_block_module_remove is exported as GPL symbol.
> 

Ignore me. Sorry for the noise, I shouldn't send patches and be on calls
at the same time ;)

I'll resend fixes for both.

Liam

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

      reply	other threads:[~2014-02-19 11:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19 11:00 [PATCH] ASoC: Intel: Fix sparse warnings for firmware loader Liam Girdwood
2014-02-19 11:06 ` Liam Girdwood
2014-02-19 11:10   ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392808230.2351.43.camel@loki \
    --to=liam.r.girdwood@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox