Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Koul, Vinod" <vinod.koul@intel.com>,
	alsa-devel@alsa-project.org,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCHv2] ASoC: Intel: sst-acpi: Request firmware before SST platform driver probing
Date: Wed, 19 Feb 2014 13:50:32 +0000	[thread overview]
Message-ID: <1392817832.2351.51.camel@loki> (raw)
In-Reply-To: <20140219122506.GN2669@sirena.org.uk>

On Wed, 2014-02-19 at 21:25 +0900, Mark Brown wrote:
> On Wed, Feb 19, 2014 at 10:30:38AM +0200, Jarkko Nikula wrote:
> > We originally thought to request SST audio DSP firmware during the SST
> > platform driver initialization. However plain request_firmware doesn't
> > work in driver probe paths if userspace is not ready to handle it. For
> > instance when drivers are built-in.
> 
> The more usual thing to do here is to only request the firmware when the
> device is actually being used (in this case on open).  This also allows
> the firmware to be replaced easily at runtime which is helpful too.  It
> seems like this is still an improvement though so I've applied it.

Fwiw, we need to load the FW at probe time since it will contain the FW
topology for the SST drivers. The next phase for the SST FW is to use
the ASoC firmware loader for DAPM, Kcontrols + DAI links (Vinod is
working on patch for DAI links iirc, I will be back to the fw loader
next week if all goes to plan). The good news is that the ASoC FW loader
can also unload FW so we should be able to re-load FW at runtime too :)

Liam

  reply	other threads:[~2014-02-19 13:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-19  8:30 [PATCHv2] ASoC: Intel: sst-acpi: Request firmware before SST platform driver probing Jarkko Nikula
2014-02-19 12:25 ` Mark Brown
2014-02-19 13:50   ` Liam Girdwood [this message]
2014-02-19 14:14     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1392817832.2351.51.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox