From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: Intel: sst-acpi: Fix Oops in case of missing firmware
Date: Tue, 25 Feb 2014 14:42:20 +0000 [thread overview]
Message-ID: <1393339340.2300.17.camel@loki> (raw)
In-Reply-To: <1393339067-10307-1-git-send-email-jarkko.nikula@linux.intel.com>
On Tue, 2014-02-25 at 16:37 +0200, Jarkko Nikula wrote:
> I swear I tested missing firmware in commit e5161d7987f1 ("ASoC: Intel:
> sst-acpi: Request firmware before SST platform driver probing").
>
> Unfortunately same wasn't done in commit 6dda27cbbd1d ("ASoC: Intel:
> sst-acpi: Add support for multiple machine drivers per platform") which
> will cause NULL pointer dereference in sst_acpi_fw_cb() when printing the
> error since sst_acpi->mach is not set.
>
> Fix this obvious error by setting the sst_acpi->mach in sst_acpi_probe().
>
> Reported-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
next prev parent reply other threads:[~2014-02-25 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 14:37 [PATCH] ASoC: Intel: sst-acpi: Fix Oops in case of missing firmware Jarkko Nikula
2014-02-25 14:42 ` Liam Girdwood [this message]
2014-02-25 16:57 ` Adam Williamson
2014-02-25 23:47 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393339340.2300.17.camel@loki \
--to=liam.r.girdwood@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox