From: "Alexander Shiyan" <shc_work@mail.ru>
To: "Markus Pargmann" <mpa@pengutronix.de>
Cc: "Fabio Estevam" <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, "Timur Tabi" <timur@tabi.org>,
"Mark Brown" <broonie@kernel.org>,
kernel@pengutronix.de,
"Nicolin Chen" <Guangyu.Chen@freescale.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 16/16] ASoC: fsl-ssi: Use regmap
Date: Sat, 15 Mar 2014 18:43:36 +0400 [thread overview]
Message-ID: <1394894616.578942243@f331.i.mail.ru> (raw)
In-Reply-To: <1394887464-969-17-git-send-email-mpa@pengutronix.de>
Суббота, 15 марта 2014, 13:44 +01:00 от Markus Pargmann <mpa@pengutronix.de>:
> This patch replaces the ssi specific functions write_ssi, read_ssi and
> write_ssi_mask by standard regmap function calls.
...
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
...
> +static const struct regmap_config fsl_ssi_regconfig = {
> + .max_register = CCSR_SSI_SACCDIS,
> + .reg_bits = 32,
> + .val_bits = 32,
> + .reg_stride = 4,
> +#ifdef PPC
> + .val_format_endian = REGMAP_ENDIAN_BIG,
> +#endif
> +};
Why we cannot use REGMAP_ENDIAN_NATIVE here for all cases?
Theoretically, we can use for i.MX SOCs with different endianness,
so this will help us.
---
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-03-15 14:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 12:44 [PATCH v2 00/16] ASoC: fsl-ssi: Driver cleanup Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 01/16] ASoC: fsl-ssi: Remove fsl_ssi_setup Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 02/16] ASoC: fsl-ssi: Fix i2s_mode variable setup Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 03/16] ASoC: fsl-ssi: Move debugging to seperate file Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 04/16] ASoC: fsl-ssi: Use dev_name for DAI driver struct Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 05/16] ASoC: fsl-ssi: Move imx-specific probe to seperate function Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 06/16] ASoC: fsl-ssi: Remove useless DMA code Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 07/16] ASoC: fsl-ssi: baud clock error handling Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 08/16] ASoC: fsl-ssi: Cleanup probe function Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 09/16] ASoC: fsl-ssi: Remove unnecessary variables from ssi_private Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 10/16] ASoC: fsl-ssi: reorder and document fsl_ssi_private Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 11/16] ASoC: fsl-ssi: Fix register values when disabling Markus Pargmann
2014-04-03 22:11 ` Mark Brown
2014-04-04 6:52 ` Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 12/16] ASoC: fsl-ssi: Only enable baudclk when used Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 13/16] ASoC: fsl-ssi: Set default dai-fmts Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 14/16] ASoC: fsl-ssi: Transmit enable synchronization Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 15/16] ASoC: fsl-ssi: Update binding documentation Markus Pargmann
2014-03-15 12:44 ` [PATCH v2 16/16] ASoC: fsl-ssi: Use regmap Markus Pargmann
2014-03-15 14:43 ` Alexander Shiyan [this message]
2014-03-18 8:10 ` Markus Pargmann
2014-03-20 6:07 ` Li.Xiubo
2014-03-20 15:10 ` Timur Tabi
2014-03-21 1:52 ` Li.Xiubo
2014-03-21 8:45 ` Markus Pargmann
2014-03-21 9:19 ` Li.Xiubo
2014-03-18 12:44 ` [PATCH v2 00/16] ASoC: fsl-ssi: Driver cleanup Mark Brown
2014-04-03 22:14 ` Mark Brown
2014-04-04 6:49 ` Markus Pargmann
2014-04-04 7:58 ` [alsa-devel] " Michael Trimarchi
2014-04-04 10:59 ` Markus Pargmann
2014-04-04 12:59 ` Michael Trimarchi
2014-04-04 10:03 ` Mark Brown
2014-04-04 10:51 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394894616.578942243@f331.i.mail.ru \
--to=shc_work@mail.ru \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mpa@pengutronix.de \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox