Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning
Date: Fri, 28 Mar 2014 19:05:04 +0100	[thread overview]
Message-ID: <1396029905-6807-1-git-send-email-zonque@gmail.com> (raw)

Document the newly added regulators to the DT binding document.

Also, "static const char const *x" is not identical to "static const
char * const x", which sparse now complains about. Fix it.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 Documentation/devicetree/bindings/sound/ak5386.txt | 4 ++++
 sound/soc/codecs/ak5386.c                          | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/sound/ak5386.txt b/Documentation/devicetree/bindings/sound/ak5386.txt
index dc3914f..ec3df3a 100644
--- a/Documentation/devicetree/bindings/sound/ak5386.txt
+++ b/Documentation/devicetree/bindings/sound/ak5386.txt
@@ -10,10 +10,14 @@ Optional properties:
 
   - reset-gpio : a GPIO spec for the reset/power down pin.
 		 If specified, it will be deasserted at probe time.
+  - va-supply : a regulator spec, providing 5.0V
+  - vd-supply : a regulator spec, providing 3.3V
 
 Example:
 
 spdif: ak5386@0 {
 	compatible = "asahi-kasei,ak5386";
 	reset-gpio = <&gpio0 23>;
+	va-supply = <&vdd_5v0_reg>;
+	vd-supply = <&vdd_3v3_reg>;
 };
diff --git a/sound/soc/codecs/ak5386.c b/sound/soc/codecs/ak5386.c
index a30be5c..8107a1c 100644
--- a/sound/soc/codecs/ak5386.c
+++ b/sound/soc/codecs/ak5386.c
@@ -19,7 +19,7 @@
 #include <sound/pcm.h>
 #include <sound/initval.h>
 
-static const char const *supply_names[] = {
+static const char * const supply_names[] = {
 	"va", "vd"
 };
 
-- 
1.8.5.3

             reply	other threads:[~2014-03-28 18:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-28 18:05 Daniel Mack [this message]
2014-03-28 18:05 ` [PATCH 2/2] ASoC: ak4104: Add regulator to documentation Daniel Mack
2014-03-29 10:17   ` Mark Brown
2014-03-29 10:17 ` [PATCH 1/2] ASoC: ak5386: Add regulators to documentation and fix sparse warning Mark Brown
2014-06-18 15:12   ` Daniel Mack
2014-06-18 17:54     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1396029905-6807-1-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox