From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ASoC: core: Fix Sparse incompatible types warning Date: Wed, 09 Apr 2014 13:12:14 +0200 Message-ID: <1397041934.11424.2.camel@AMDC1943> References: <1397028108-10976-1-git-send-email-k.kozlowski@samsung.com> <5345279F.6070005@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-reply-to: <5345279F.6070005@metafoo.de> Sender: linux-kernel-owner@vger.kernel.org To: Lars-Peter Clausen Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On =C5=9Bro, 2014-04-09 at 12:57 +0200, Lars-Peter Clausen wrote: > On 04/09/2014 09:21 AM, Krzysztof Kozlowski wrote: > > Fix following Sparse warning: > > sound/soc/soc-core.c:252:20: error: incompatible types in compariso= n expression (different type sizes) > > > > Signed-off-by: Krzysztof Kozlowski > > --- > > sound/soc/soc-core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c > > index 051c006281f5..41f6178249df 100644 > > --- a/sound/soc/soc-core.c > > +++ b/sound/soc/soc-core.c > > @@ -249,7 +249,7 @@ static ssize_t codec_reg_write_file(struct file= *file, > > struct snd_soc_codec *codec =3D file->private_data; > > int ret; > > > > - buf_size =3D min(count, (sizeof(buf)-1)); > > + buf_size =3D min(count, (size_t)(sizeof(buf)-1)); >=20 > But shouldn't the type of sizeof already be size_t? Hmmm... yes it should. It looks like a false positive from Sparse so th= e commit message should be rather "Suppress" than "Fix". Best regards, Krzysztof