From: Anssi Hannula <anssi.hannula@iki.fi>
To: Shawn Guo <shawn.guo@freescale.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Nicolin Chen <Guangyu.Chen@freescale.com>
Subject: [PATCH 2/2] ARM: dts: imx6: remove non-working spdif rxtx4 and rxtx6 clocks
Date: Mon, 16 Jun 2014 02:39:45 +0300 [thread overview]
Message-ID: <1402875585-29025-2-git-send-email-anssi.hannula@iki.fi> (raw)
In-Reply-To: <1402875585-29025-1-git-send-email-anssi.hannula@iki.fi>
The S/PDIF rxtx4 and rxtx6 clock inputs are "ESAI_HCKT" and "MLB clock",
respectively, according to the SoC documentation, and they are currently
mapped to clocks "esai" and "mlb".
However, they do not seem to actually work correctly. Testing on a
Cubox-i system with fsl_spdif driver forced to select one of those as
input will result in I/O errors on audio playback, which I believe means
missing clock signal.
Possibly the "ESAI_HCKT" and "MLB clock" refer to some other clocks
related to ESAI and MLB, or we are missing something else.
Since audio playback will not work if fsl_spdif selects these clocks
(which happens rarely), set the inputs do dummy clocks, at least for
now.
Signed-off-by: Anssi Hannula <anssi.hannula@iki.fi>
Cc: Nicolin Chen <Guangyu.Chen@freescale.com>
Cc: Mark Brown <broonie@kernel.org>
---
Does anyone know what is wrong here? i.e. are the clocks actually wrong
or are we maybe doing something wrong with their setup?
Also, is this the correct way to "fix" the issue, or should we rather
modify the driver to not select rxtx4/rxtx6 for now (assuming no one knows
how to fix this properly, of course)?
(I haven't been involved with device trees before)
arch/arm/boot/dts/imx6qdl.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
index 3aef9a2f5fda..f0d1c2334952 100644
--- a/arch/arm/boot/dts/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/imx6qdl.dtsi
@@ -182,8 +182,8 @@
dma-names = "rx", "tx";
clocks = <&clks 197>, <&clks 3>,
<&clks 197>, <&clks 0>,
- <&clks 0>, <&clks 118>,
- <&clks 0>, <&clks 139>,
+ <&clks 0>, <&clks 0>,
+ <&clks 0>, <&clks 0>,
<&clks 0>;
clock-names = "core", "rxtx0",
"rxtx1", "rxtx2",
--
1.8.4.5
next prev parent reply other threads:[~2014-06-15 23:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-15 23:39 [PATCH 1/2] ARM: dts: imx6: remove wrong spdif rxtx2 clock Anssi Hannula
2014-06-15 23:39 ` Anssi Hannula [this message]
2014-06-16 2:31 ` [PATCH 2/2] ARM: dts: imx6: remove non-working spdif rxtx4 and rxtx6 clocks Nicolin Chen
2014-06-16 2:27 ` [PATCH 1/2] ARM: dts: imx6: remove wrong spdif rxtx2 clock Nicolin Chen
2014-06-20 7:58 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1402875585-29025-2-git-send-email-anssi.hannula@iki.fi \
--to=anssi.hannula@iki.fi \
--cc=Guangyu.Chen@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).