* [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
@ 2014-07-23 0:55 libin.yang
2014-07-23 0:55 ` [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec libin.yang
2014-07-23 10:07 ` [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell Takashi Iwai
0 siblings, 2 replies; 9+ messages in thread
From: libin.yang @ 2014-07-23 0:55 UTC (permalink / raw)
To: alsa-devel, tiwai, mengdong.lin; +Cc: Libin Yang
From: Libin Yang <libin.yang@intel.com>
Add HD Audio Device PCI ID for the Intel Braswell platform.
Signed-off-by: Libin Yang <libin.yang@intel.com>
---
sound/pci/hda/hda_intel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 387fc73..f758729 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
/* BayTrail */
{ PCI_DEVICE(0x8086, 0x0f04),
.driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
+ /* Braswell */
+ { PCI_DEVICE(0x8086, 0x2284),
+ .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
/* ICH */
{ PCI_DEVICE(0x8086, 0x2668),
.driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec
2014-07-23 0:55 [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell libin.yang
@ 2014-07-23 0:55 ` libin.yang
2014-07-23 10:07 ` [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell Takashi Iwai
1 sibling, 0 replies; 9+ messages in thread
From: libin.yang @ 2014-07-23 0:55 UTC (permalink / raw)
To: alsa-devel, tiwai, mengdong.lin; +Cc: Libin Yang
From: Libin Yang <libin.yang@intel.com>
This patch adds codec ID (0x80862883) and module alias for Braswell
display codec.
Signed-off-by: Libin Yang <libin.yang@intel.com>
---
sound/pci/hda/patch_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index a21090b..36badba 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
{ .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi },
+{ .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x808629fb, .name = "Crestline HDMI", .patch = patch_generic_hdmi },
{} /* terminator */
};
@@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807");
MODULE_ALIAS("snd-hda-codec-id:80862808");
MODULE_ALIAS("snd-hda-codec-id:80862880");
MODULE_ALIAS("snd-hda-codec-id:80862882");
+MODULE_ALIAS("snd-hda-codec-id:80862883");
MODULE_ALIAS("snd-hda-codec-id:808629fb");
MODULE_LICENSE("GPL");
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
2014-07-23 0:55 [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell libin.yang
2014-07-23 0:55 ` [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec libin.yang
@ 2014-07-23 10:07 ` Takashi Iwai
2014-07-24 3:57 ` Yang, Libin
1 sibling, 1 reply; 9+ messages in thread
From: Takashi Iwai @ 2014-07-23 10:07 UTC (permalink / raw)
To: libin.yang; +Cc: mengdong.lin, alsa-devel
At Wed, 23 Jul 2014 08:55:37 +0800,
libin.yang@intel.com wrote:
>
> From: Libin Yang <libin.yang@intel.com>
>
> Add HD Audio Device PCI ID for the Intel Braswell platform.
>
> Signed-off-by: Libin Yang <libin.yang@intel.com>
> ---
> sound/pci/hda/hda_intel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 387fc73..f758729 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
> /* BayTrail */
> { PCI_DEVICE(0x8086, 0x0f04),
> .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
> + /* Braswell */
> + { PCI_DEVICE(0x8086, 0x2284),
> + .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM },
Doesn't really this new chip support runtime PM?
Takashi
> /* ICH */
> { PCI_DEVICE(0x8086, 0x2668),
> .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
2014-07-23 10:07 ` [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell Takashi Iwai
@ 2014-07-24 3:57 ` Yang, Libin
2014-07-24 12:59 ` Yang, Libin
0 siblings, 1 reply; 9+ messages in thread
From: Yang, Libin @ 2014-07-24 3:57 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Lin, Mengdong, alsa-devel@alsa-project.org
Hi Takashi,
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Wednesday, July 23, 2014 6:08 PM
> To: Yang, Libin
> Cc: alsa-devel@alsa-project.org; Lin, Mengdong
> Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
>
> At Wed, 23 Jul 2014 08:55:37 +0800,
> libin.yang@intel.com wrote:
> >
> > From: Libin Yang <libin.yang@intel.com>
> >
> > Add HD Audio Device PCI ID for the Intel Braswell platform.
> >
> > Signed-off-by: Libin Yang <libin.yang@intel.com>
> > ---
> > sound/pci/hda/hda_intel.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 387fc73..f758729 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
> > /* BayTrail */
> > { PCI_DEVICE(0x8086, 0x0f04),
> > .driver_data = AZX_DRIVER_PCH |
> AZX_DCAPS_INTEL_PCH_NOPM },
> > + /* Braswell */
> > + { PCI_DEVICE(0x8086, 0x2284),
> > + .driver_data = AZX_DRIVER_PCH |
> AZX_DCAPS_INTEL_PCH_NOPM },
>
> Doesn't really this new chip support runtime PM?
Braswell is more like Baytrail, which doesn't support runtime PM.
Anyway, I will test the pm-runtime on braswell and update the result later.
>
>
> Takashi
>
> > /* ICH */
> > { PCI_DEVICE(0x8086, 0x2668),
> > .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
> > --
> > 1.9.1
> >
Regards,
Libin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
2014-07-24 3:57 ` Yang, Libin
@ 2014-07-24 12:59 ` Yang, Libin
2014-07-24 13:21 ` Takashi Iwai
0 siblings, 1 reply; 9+ messages in thread
From: Yang, Libin @ 2014-07-24 12:59 UTC (permalink / raw)
To: 'Takashi Iwai'
Cc: Lin, Mengdong, 'alsa-devel@alsa-project.org'
Hi Takashi,
After checking the HW, the HDMI audio codec doesn't support EPSS. If we force it to support runtime PM, there is risk. Besides, as the codec doesn't support EPSS, if we want to support runtime PM, simply add the AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method to ensure the driver enter pm runtime even the codec doesn't support.
What do you think whether we can merge the patch firstly, and on the meantime, I will ask our QA team to do a full test with pm runtime enabled and decide the next step?
Regards,
Libin
> -----Original Message-----
> From: Yang, Libin
> Sent: Thursday, July 24, 2014 11:57 AM
> To: Takashi Iwai
> Cc: alsa-devel@alsa-project.org; Lin, Mengdong
> Subject: RE: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
>
> Hi Takashi,
>
> > -----Original Message-----
> > From: Takashi Iwai [mailto:tiwai@suse.de]
> > Sent: Wednesday, July 23, 2014 6:08 PM
> > To: Yang, Libin
> > Cc: alsa-devel@alsa-project.org; Lin, Mengdong
> > Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
> >
> > At Wed, 23 Jul 2014 08:55:37 +0800,
> > libin.yang@intel.com wrote:
> > >
> > > From: Libin Yang <libin.yang@intel.com>
> > >
> > > Add HD Audio Device PCI ID for the Intel Braswell platform.
> > >
> > > Signed-off-by: Libin Yang <libin.yang@intel.com>
> > > ---
> > > sound/pci/hda/hda_intel.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > > index 387fc73..f758729 100644
> > > --- a/sound/pci/hda/hda_intel.c
> > > +++ b/sound/pci/hda/hda_intel.c
> > > @@ -2017,6 +2017,9 @@ static const struct pci_device_id azx_ids[] = {
> > > /* BayTrail */
> > > { PCI_DEVICE(0x8086, 0x0f04),
> > > .driver_data = AZX_DRIVER_PCH |
> > AZX_DCAPS_INTEL_PCH_NOPM },
> > > + /* Braswell */
> > > + { PCI_DEVICE(0x8086, 0x2284),
> > > + .driver_data = AZX_DRIVER_PCH |
> > AZX_DCAPS_INTEL_PCH_NOPM },
> >
> > Doesn't really this new chip support runtime PM?
>
> Braswell is more like Baytrail, which doesn't support runtime PM.
>
> Anyway, I will test the pm-runtime on braswell and update the result later.
>
> >
> >
> > Takashi
> >
> > > /* ICH */
> > > { PCI_DEVICE(0x8086, 0x2668),
> > > .driver_data = AZX_DRIVER_ICH | AZX_DCAPS_OLD_SSYNC |
> > > --
> > > 1.9.1
> > >
>
> Regards,
> Libin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
2014-07-24 12:59 ` Yang, Libin
@ 2014-07-24 13:21 ` Takashi Iwai
2014-07-25 1:06 ` Yang, Libin
0 siblings, 1 reply; 9+ messages in thread
From: Takashi Iwai @ 2014-07-24 13:21 UTC (permalink / raw)
To: Yang, Libin; +Cc: Lin, Mengdong, 'alsa-devel@alsa-project.org'
At Thu, 24 Jul 2014 12:59:55 +0000,
Yang, Libin wrote:
>
> Hi Takashi,
>
> After checking the HW, the HDMI audio codec doesn't support EPSS. If we force it to support runtime PM, there is risk. Besides, as the codec doesn't support EPSS, if we want to support runtime PM, simply add the AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method to ensure the driver enter pm runtime even the codec doesn't support.
Wait, is the controller for the generic codecs or dedicated to the
embedded HDMI? In the latter case, AZX_DCAPS_INTEL_PCM_NOPM is anyway
wrong. For HDMI, we use different flags.
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
2014-07-24 13:21 ` Takashi Iwai
@ 2014-07-25 1:06 ` Yang, Libin
0 siblings, 0 replies; 9+ messages in thread
From: Yang, Libin @ 2014-07-25 1:06 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Lin, Mengdong, 'alsa-devel@alsa-project.org'
Hi Takashi,
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Thursday, July 24, 2014 9:21 PM
> To: Yang, Libin
> Cc: 'alsa-devel@alsa-project.org'; Lin, Mengdong
> Subject: Re: [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell
>
> At Thu, 24 Jul 2014 12:59:55 +0000,
> Yang, Libin wrote:
> >
> > Hi Takashi,
> >
> > After checking the HW, the HDMI audio codec doesn't support EPSS. If we
> force it to support runtime PM, there is risk. Besides, as the codec doesn't
> support EPSS, if we want to support runtime PM, simply add the
> AZX_DCAPS_PM_RUNTIME flag doesn't help. We must think out a method
> to ensure the driver enter pm runtime even the codec doesn't support.
>
> Wait, is the controller for the generic codecs or dedicated to the embedded
> HDMI? In the latter case, AZX_DCAPS_INTEL_PCM_NOPM is anyway wrong.
> For HDMI, we use different flags.
OK, I see. I will add the flags and have a test.
>
>
> Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec
2014-07-25 8:19 libin.yang
@ 2014-07-25 8:19 ` libin.yang
0 siblings, 0 replies; 9+ messages in thread
From: libin.yang @ 2014-07-25 8:19 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: Libin Yang, mengdong.lin
From: Libin Yang <libin.yang@intel.com>
This patch adds codec ID (0x80862883) and module alias for Braswell
display codec.
Signed-off-by: Libin Yang <libin.yang@intel.com>
---
sound/pci/hda/patch_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index a21090b..36badba 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
{ .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi },
+{ .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x808629fb, .name = "Crestline HDMI", .patch = patch_generic_hdmi },
{} /* terminator */
};
@@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807");
MODULE_ALIAS("snd-hda-codec-id:80862808");
MODULE_ALIAS("snd-hda-codec-id:80862880");
MODULE_ALIAS("snd-hda-codec-id:80862882");
+MODULE_ALIAS("snd-hda-codec-id:80862883");
MODULE_ALIAS("snd-hda-codec-id:808629fb");
MODULE_LICENSE("GPL");
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec
2014-08-04 1:22 [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell libin.yang
@ 2014-08-04 1:22 ` libin.yang
0 siblings, 0 replies; 9+ messages in thread
From: libin.yang @ 2014-08-04 1:22 UTC (permalink / raw)
To: alsa-devel, tiwai; +Cc: Libin Yang, mengdong.lin
From: Libin Yang <libin.yang@intel.com>
This patch adds codec ID (0x80862883) and module alias for Braswell
display codec.
Signed-off-by: Libin Yang <libin.yang@intel.com>
---
sound/pci/hda/patch_hdmi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/pci/hda/patch_hdmi.c b/sound/pci/hda/patch_hdmi.c
index a21090b..36badba 100644
--- a/sound/pci/hda/patch_hdmi.c
+++ b/sound/pci/hda/patch_hdmi.c
@@ -3356,6 +3356,7 @@ static const struct hda_codec_preset snd_hda_preset_hdmi[] = {
{ .id = 0x80862808, .name = "Broadwell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862880, .name = "CedarTrail HDMI", .patch = patch_generic_hdmi },
{ .id = 0x80862882, .name = "Valleyview2 HDMI", .patch = patch_generic_hdmi },
+{ .id = 0x80862883, .name = "Braswell HDMI", .patch = patch_generic_hdmi },
{ .id = 0x808629fb, .name = "Crestline HDMI", .patch = patch_generic_hdmi },
{} /* terminator */
};
@@ -3415,6 +3416,7 @@ MODULE_ALIAS("snd-hda-codec-id:80862807");
MODULE_ALIAS("snd-hda-codec-id:80862808");
MODULE_ALIAS("snd-hda-codec-id:80862880");
MODULE_ALIAS("snd-hda-codec-id:80862882");
+MODULE_ALIAS("snd-hda-codec-id:80862883");
MODULE_ALIAS("snd-hda-codec-id:808629fb");
MODULE_LICENSE("GPL");
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-08-04 1:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 0:55 [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell libin.yang
2014-07-23 0:55 ` [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec libin.yang
2014-07-23 10:07 ` [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell Takashi Iwai
2014-07-24 3:57 ` Yang, Libin
2014-07-24 12:59 ` Yang, Libin
2014-07-24 13:21 ` Takashi Iwai
2014-07-25 1:06 ` Yang, Libin
-- strict thread matches above, loose matches on Subject: below --
2014-07-25 8:19 libin.yang
2014-07-25 8:19 ` [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec libin.yang
2014-08-04 1:22 [PATCH 1/2] ALSA: hda - add PCI IDs for Intel Braswell libin.yang
2014-08-04 1:22 ` [PATCH 2/2] ALSA: hda - add codec ID for Braswell display audio codec libin.yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).