From: "Peter S. Housel" <housel@acm.org>
To: alsa-devel@alsa-project.org
Cc: "Peter S. Housel" <housel@acm.org>, jsarha@ti.com
Subject: [PATCH] ASoC: tlv320aic31xx: place codec into reset state initially
Date: Mon, 4 Aug 2014 15:13:21 -0700 [thread overview]
Message-ID: <1407190401-3712-1-git-send-email-housel@acm.org> (raw)
Previously the driver would only place the TLV320AIC31XX into reset
using the gpio reset line when at least one of the power supply
regulators was disabled, so that if these supplies were always enabled
no reset would ever occur. This change resets the codec state at probe
time so that the initial register cache values are correct.
Signed-off-by: Peter S. Housel <housel@acm.org>
---
sound/soc/codecs/tlv320aic31xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
index 0f64c78..89a4daf 100644
--- a/sound/soc/codecs/tlv320aic31xx.c
+++ b/sound/soc/codecs/tlv320aic31xx.c
@@ -1194,7 +1194,7 @@ static int aic31xx_device_init(struct aic31xx_priv *aic31xx)
if (aic31xx->pdata.gpio_reset) {
ret = devm_gpio_request_one(aic31xx->dev,
aic31xx->pdata.gpio_reset,
- GPIOF_OUT_INIT_HIGH,
+ GPIOF_OUT_INIT_LOW,
"aic31xx-reset-pin");
if (ret < 0) {
dev_err(aic31xx->dev, "not able to acquire gpio\n");
--
1.9.1
next reply other threads:[~2014-08-04 22:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 22:13 Peter S. Housel [this message]
2014-08-05 7:34 ` [PATCH] ASoC: tlv320aic31xx: place codec into reset state initially Jyri Sarha
[not found] ` <avb91o01X1j0zgo01vbBxr>
2014-09-02 20:25 ` Peter S. Housel
2014-09-02 22:31 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407190401-3712-1-git-send-email-housel@acm.org \
--to=housel@acm.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).