Re: [PATCH] ASoC: rt286: Add API to set supported jack type

[Liam Girdwood <liam.r.girdwood@linux.intel.com>]

On Mon, 2014-08-11 at 13:24 +0100, Mark Brown wrote:
> On Mon, Aug 11, 2014 at 10:59:45AM +0100, Liam Girdwood wrote:
> > On Thu, 2014-08-07 at 18:31 +0100, Mark Brown wrote:
> 
> > > I've CCed in Graeme Gregory who's been writing some guidelines for this
> > > sort of thing in the context of ARMv8 serviers - the most recent patch
> > > is:
> 
> > >    http://thread.gmane.org/gmane.linux.acpi.devel/69757
> 
> > > The advice there looks good to me - see the "Device Enumeration"
> > > section.
> 
> > This is indeed good, just too late for the initial Broadwell BIOSes that
> > wont have this _DSD field for the codec (it will be hard coded for
> > Windows anyway).
> 
> Sounds like DMI is going to be needed then - whatever ends up being done
> I'd expect it should just be a case of putting the checks done to work
> out the machine configuration into the CODEC driver instead of the
> machine driver.  If it looks ugly this can be used to explain to people
> why we need something more sensible!

It sure will be ugly ;) This would involve the codec driver checking for
the existence of the Broadwell ADSP ACPI ID and then configuring jack
mode depending on whether it finds this ID or not.

We have the opposite implementation atm where the Broadwell machine
driver sets the jack mode at machine driver init time.

I'm not sure that showing ugly code here would help justify anything
either as we will kind of be at the mercy of whether the Windows driver
needs this information or not.

Liam