alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jurgen Kramer <gtmkramer@xs4all.nl>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] pcm/kernel: Add DSD formats silence patterns
Date: Mon, 25 Aug 2014 10:18:10 +0200	[thread overview]
Message-ID: <1408954690.3063.1.camel@xs4all.nl> (raw)
In-Reply-To: <s5hlhqdt4m4.wl-tiwai@suse.de>

On Mon, 2014-08-25 at 09:23 +0200, Takashi Iwai wrote:
> At Sun, 24 Aug 2014 10:04:08 +0200,
> Jurgen Kramer wrote:
> > 
> > This patch adds the silence patterns for the DSD sample formats, kernel side.
> > 
> > Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
> 
> A similar patch has been already submitted and merged :)
> 
OK thanks, must have missed it.

BTW I could not find it in your git repo or current kernel git, where is
is hiding? :-)

Jurgen

> thanks,
> 
> Takashi
> 
> > ---
> >  sound/core/pcm_misc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/sound/core/pcm_misc.c b/sound/core/pcm_misc.c
> > index 4560ca0..2c6fd80 100644
> > --- a/sound/core/pcm_misc.c
> > +++ b/sound/core/pcm_misc.c
> > @@ -142,11 +142,11 @@ static struct pcm_format_data pcm_formats[(INT)SNDRV_PCM_FORMAT_LAST+1] = {
> >  	},
> >  	[SNDRV_PCM_FORMAT_DSD_U8] = {
> >  		.width = 8, .phys = 8, .le = 1, .signd = 0,
> > -		.silence = {},
> > +		.silence = { 0x69 },
> >  	},
> >  	[SNDRV_PCM_FORMAT_DSD_U16_LE] = {
> >  		.width = 16, .phys = 16, .le = 1, .signd = 0,
> > -		.silence = {},
> > +		.silence = { 0x69, 0x69 },
> >  	},
> >  	/* FIXME: the following three formats are not defined properly yet */
> >  	[SNDRV_PCM_FORMAT_MPEG] = {
> > -- 
> > 1.9.3
> > 
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> > 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> 

  reply	other threads:[~2014-08-25  8:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24  8:04 [PATCH] pcm/kernel: Add DSD formats silence patterns Jurgen Kramer
2014-08-25  7:23 ` Takashi Iwai
2014-08-25  8:18   ` Jurgen Kramer [this message]
2014-08-25  8:20     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1408954690.3063.1.camel@xs4all.nl \
    --to=gtmkramer@xs4all.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).