From: Joe Perches <joe@perches.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sound: pci: ctxfi: pr_* replaced with dev_*
Date: Mon, 15 Sep 2014 07:35:01 -0700 [thread overview]
Message-ID: <1410791701.18787.3.camel@joe-AO725> (raw)
In-Reply-To: <1410790181-16457-1-git-send-email-sudipm.mukherjee@gmail.com>
On Mon, 2014-09-15 at 19:39 +0530, Sudip Mukherjee wrote:
> pr_* macros replaced with dev_* as they are more preffered over pr_*.
[]
> diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
[]
> @@ -1282,8 +1282,8 @@ static int atc_identify_card(struct ct_atc *atc, unsigned int ssid)
> p = snd_pci_quirk_lookup_id(vendor_id, device_id, list);
> if (p) {
> if (p->value < 0) {
> - pr_err("ctxfi: Device %04x:%04x is black-listed\n",
> - vendor_id, device_id);
> + dev_err(atc->card->dev, "ctxfi: Device %04x:%04x is black-listed\n",
> + vendor_id, device_id);
You should probably remove the "ctxfi: " from the dev_<level>
uses as the card->dev name is emitted by dev_err
dev_err(atc->card->dev, "Device %04x:%04x is black-listed\n",
vendor_id, device_id);
etc...
prev parent reply other threads:[~2014-09-15 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 14:09 [PATCH v2] sound: pci: ctxfi: pr_* replaced with dev_* Sudip Mukherjee
2014-09-15 14:29 ` Takashi Iwai
2014-09-15 15:25 ` Sudip Mukherjee
2014-09-15 18:17 ` Takashi Iwai
2014-09-18 9:21 ` Sudip Mukherjee
2014-09-18 10:21 ` Takashi Iwai
2014-09-18 11:31 ` Sudip Mukherjee
2014-09-15 14:35 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410791701.18787.3.camel@joe-AO725 \
--to=joe@perches.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).