From: Liam Girdwood <liam.r.girdwood@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, graeme.gregory@linaro.org, lgirdwood@gmail.com,
bardliao@realtek.com, flove@realtek.com
Subject: Re: [PATCH v2] ASoC: rt286: Set cbj_en for ACPI devices
Date: Tue, 16 Sep 2014 08:31:54 +0100 [thread overview]
Message-ID: <1410852714.23184.49.camel@loki> (raw)
In-Reply-To: <20140912135558.GW7960@sirena.org.uk>
On Fri, 2014-09-12 at 14:55 +0100, Mark Brown wrote:
> On Thu, Sep 11, 2014 at 09:40:54AM +0800, bardliao@realtek.com wrote:
>
> > +/* the default platform data for acpi devices */
> > +static struct rt286_platform_data rt286_acpi_data = {
> > + .cbj_en = true,
> > + .gpio2_en = false,
> > +};
> > +
> > static const struct acpi_device_id rt286_acpi_match[] = {
> > - { "INT343A", 0 },
> > + { "INT343A", (unsigned long)&rt286_acpi_data },
> > {},
> > };
>
> Why does this platform data apply to all boards using this ACPI ID?
> Shouldn't this be _DSD data instead, or should we be doing quirks based
> on DMI data?
Sadly there is no data within most/all current BIOSes that have this
ACPI id for the RT286. The BIOSes are a little behind in the development
here compared to the codec driver. So it's probably we will have to
support this and _DSD with this particular driver.
Liam
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2014-09-16 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 1:40 [PATCH v2] ASoC: rt286: Set cbj_en for ACPI devices bardliao
2014-09-12 13:55 ` Mark Brown
2014-09-16 7:31 ` Liam Girdwood [this message]
2014-09-16 16:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410852714.23184.49.camel@loki \
--to=liam.r.girdwood@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=graeme.gregory@linaro.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).