alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Fabio.Estevam@freescale.com" <Fabio.Estevam@freescale.com>
To: Timur Tabi <timur@tabi.org>, Nicolin Chen <nicoleotsuka@gmail.com>
Cc: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"broonie@kernel.org" <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property
Date: Thu, 18 Sep 2014 18:46:42 +0000	[thread overview]
Message-ID: <1411065995187.3341@freescale.com> (raw)
In-Reply-To: <541B2678.8000401@tabi.org>

Sorry, I missed to add alsa-devel@alsa-project.org on Cc.
________________________________________
From: Timur Tabi <timur@tabi.org>
Sent: Thursday, September 18, 2014 3:37 PM
To: Nicolin Chen
Cc: Estevam Fabio-R49496; broonie@kernel.org; Xiubo Li-B47053
Subject: Re: [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property

On 09/18/2014 01:32 PM, Nicolin Chen wrote:
> On Thu, Sep 18, 2014 at 03:11:17PM -0300, Fabio Estevam wrote:
>> There is no need to use 'i2s-slave' property, since master/slave configuration
>> are passed via machine layer.
>>
>> This change does not break existing users because they do check for slave
>> mode inside sound/soc/fsl/mpc8610_hpcd.c/p1022_ds.c and p1022_rdk.c
>
> Besides this change, I'm wondering if we can take a further step to drop
> this entire property from Device Tree binding document as newer platforms
> may no long need this property in their DT bindings.

I think the property is necessary if anyone takes a P1022 or MPC8610 and
uses it in a platform that doesn't support i2s-slave.  But currently,
the code doesn't support anything else.  So technically, we could remove
it, and if anyone does want to support another configuration, he will
have to add that support the "new" way.

       reply	other threads:[~2014-09-18 18:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1411063877-1552-1-git-send-email-fabio.estevam@freescale.com>
     [not found] ` <20140918183251.GE6432@Asurada>
     [not found]   ` <541B2678.8000401@tabi.org>
2014-09-18 18:46     ` Fabio.Estevam [this message]
2014-09-18 19:43       ` [PATCH] ASoC: fsl_ssi: Remove unneeded 'i2s-slave' property Nicolin Chen
2014-09-19  0:29         ` Timur Tabi
2014-09-19  4:17           ` Nicolin Chen
2014-09-19 12:51             ` Timur Tabi
2014-09-19 17:24               ` Nicolin Chen
2014-09-19 23:49                 ` Timur Tabi
2014-09-20 18:07                   ` Nicolin Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411065995187.3341@freescale.com \
    --to=fabio.estevam@freescale.com \
    --cc=Li.Xiubo@freescale.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=nicoleotsuka@gmail.com \
    --cc=timur@tabi.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).