From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
stable@vger.kernel.org
Subject: [PATCH 1/6] ASoC: sigmadsp: Refuse to load firmware files with a non-supported version
Date: Wed, 19 Nov 2014 18:29:02 +0100 [thread overview]
Message-ID: <1416418148-14803-1-git-send-email-lars@metafoo.de> (raw)
Make sure to check the version field of the firmware header to make sure to
not accidentally try to parse a firmware file with a different layout.
Trying to do so can result in loading invalid firmware code to the device.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Cc: stable@vger.kernel.org
---
sound/soc/codecs/sigmadsp.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sound/soc/codecs/sigmadsp.c b/sound/soc/codecs/sigmadsp.c
index f2de7e0..81a38dd 100644
--- a/sound/soc/codecs/sigmadsp.c
+++ b/sound/soc/codecs/sigmadsp.c
@@ -159,6 +159,13 @@ int _process_sigma_firmware(struct device *dev,
goto done;
}
+ if (ssfw_head->version != 1) {
+ dev_err(dev,
+ "Failed to load firmware: Invalid version %d. Supported firmware versions: 1\n",
+ ssfw_head->version);
+ goto done;
+ }
+
crc = crc32(0, fw->data + sizeof(*ssfw_head),
fw->size - sizeof(*ssfw_head));
pr_debug("%s: crc=%x\n", __func__, crc);
--
1.8.0
next reply other threads:[~2014-11-19 17:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 17:29 Lars-Peter Clausen [this message]
2014-11-19 17:29 ` [PATCH 2/6] ASoC: adau17x1: Mark DSP parameter memory as readable and precious Lars-Peter Clausen
2014-11-21 16:30 ` Lars-Peter Clausen
2014-11-21 16:38 ` Mark Brown
2014-11-19 17:29 ` [PATCH 3/6] ASoC: sigmadsp: Drop support support SIGMA_ACTION_DELAY Lars-Peter Clausen
2014-11-19 17:29 ` [PATCH 4/6] ASoC: sigmadsp: Restructure in preparation for fw v2 support Lars-Peter Clausen
2014-11-19 17:29 ` [PATCH 5/6] ASoC: sigmadsp: Add support for fw v2 Lars-Peter Clausen
2014-11-19 17:29 ` [PATCH 6/6] ASoC: adau1701: Implement sigmadsp safeload Lars-Peter Clausen
2014-11-20 9:56 ` [PATCH 1/6] ASoC: sigmadsp: Refuse to load firmware files with a non-supported version Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416418148-14803-1-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox