alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
	Jyri Sarha <jsarha@ti.com>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>,
	Vishwas A Deshpande <vishwas.a.deshpande@ti.com>,
	M R Swami Reddy <mr.swami.reddy@ti.com>
Subject: [PATCH 11/11] ASoC: twl6040: Cleanup manual bias level transitions
Date: Wed, 26 Nov 2014 20:58:00 +0100	[thread overview]
Message-ID: <1417031880-11364-11-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1417031880-11364-1-git-send-email-lars@metafoo.de>

Set the CODEC driver's suspend_bias_off flag rather than manually going to
SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes
the code a bit shorter and cleaner.

Since the ASoC core now takes care of setting the bias level to
SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually
anymore either.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
 sound/soc/codecs/twl6040.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/sound/soc/codecs/twl6040.c b/sound/soc/codecs/twl6040.c
index 0f6067f..5ff2b1e 100644
--- a/sound/soc/codecs/twl6040.c
+++ b/sound/soc/codecs/twl6040.c
@@ -1095,25 +1095,6 @@ static struct snd_soc_dai_driver twl6040_dai[] = {
 },
 };
 
-#ifdef CONFIG_PM
-static int twl6040_suspend(struct snd_soc_codec *codec)
-{
-	twl6040_set_bias_level(codec, SND_SOC_BIAS_OFF);
-
-	return 0;
-}
-
-static int twl6040_resume(struct snd_soc_codec *codec)
-{
-	twl6040_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
-	return 0;
-}
-#else
-#define twl6040_suspend NULL
-#define twl6040_resume NULL
-#endif
-
 static int twl6040_probe(struct snd_soc_codec *codec)
 {
 	struct twl6040_data *priv;
@@ -1160,7 +1141,6 @@ static int twl6040_remove(struct snd_soc_codec *codec)
 	struct twl6040_data *priv = snd_soc_codec_get_drvdata(codec);
 
 	free_irq(priv->plug_irq, codec);
-	twl6040_set_bias_level(codec, SND_SOC_BIAS_OFF);
 
 	return 0;
 }
@@ -1168,11 +1148,10 @@ static int twl6040_remove(struct snd_soc_codec *codec)
 static struct snd_soc_codec_driver soc_codec_dev_twl6040 = {
 	.probe = twl6040_probe,
 	.remove = twl6040_remove,
-	.suspend = twl6040_suspend,
-	.resume = twl6040_resume,
 	.read = twl6040_read,
 	.write = twl6040_write,
 	.set_bias_level = twl6040_set_bias_level,
+	.suspend_bias_off = true,
 	.ignore_pmdown_time = true,
 
 	.controls = twl6040_snd_controls,
-- 
1.8.0

  parent reply	other threads:[~2014-11-26 21:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 19:57 [PATCH 01/11] ASoC: cq93vc: Remove unused state struct Lars-Peter Clausen
2014-11-26 19:57 ` [PATCH 02/11] ASoC: cq93vc: Cleanup manual bias level transitions Lars-Peter Clausen
2014-11-27 11:11   ` Mark Brown
2014-11-26 19:57 ` [PATCH 03/11] ASoC: lm49453: " Lars-Peter Clausen
2014-11-27 11:14   ` Mark Brown
2014-11-26 19:57 ` [PATCH 04/11] ASoC: sn95031: Cleanup " Lars-Peter Clausen
2014-11-27 11:15   ` Mark Brown
2014-11-26 19:57 ` [PATCH 05/11] ASoC: tlv320aic23: Cleanup manual " Lars-Peter Clausen
2014-11-27 11:15   ` Mark Brown
2014-11-26 19:57 ` [PATCH 06/11] ASoC: tlv320aix31xx: " Lars-Peter Clausen
2014-11-27  8:30   ` Jyri Sarha
2014-11-27 11:16   ` Mark Brown
2014-11-26 19:57 ` [PATCH 07/11] ASoC: tlv320aic32x4: " Lars-Peter Clausen
2014-11-27 11:16   ` Mark Brown
2014-11-26 19:57 ` [PATCH 08/11] ASoC: tlv320aic3x: " Lars-Peter Clausen
2014-11-27 11:17   ` Mark Brown
2014-11-26 19:57 ` [PATCH 09/11] ASoC: tlv320dac33: " Lars-Peter Clausen
2014-11-27 11:17   ` Mark Brown
2014-11-26 19:57 ` [PATCH 10/11] ASoC: twl4030: " Lars-Peter Clausen
2014-11-27 11:18   ` Mark Brown
2014-11-26 19:58 ` Lars-Peter Clausen [this message]
2014-11-27 11:18   ` [PATCH 11/11] ASoC: twl6040: " Mark Brown
2014-11-27 11:11 ` [PATCH 01/11] ASoC: cq93vc: Remove unused state struct Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417031880-11364-11-git-send-email-lars@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jsarha@ti.com \
    --cc=lgirdwood@gmail.com \
    --cc=mr.swami.reddy@ti.com \
    --cc=peter.ujfalusi@ti.com \
    --cc=vishwas.a.deshpande@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).