alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jurgen Kramer <gtmkramer@xs4all.nl>
To: "Alexander E. Patrakov" <patrakov@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl>
Date: Fri, 28 Nov 2014 13:40:36 +0100	[thread overview]
Message-ID: <1417178436.2994.0.camel@xs4all.nl> (raw)
In-Reply-To: <54786C97.4050002@gmail.com>

On Fri, 2014-11-28 at 17:37 +0500, Alexander E. Patrakov wrote:
> 28.11.2014 17:31, Jurgen Kramer wrote:
> > +		case 2: /* DSD mode requested */
> > +			err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), 0,
> > +					      USB_DIR_OUT|USB_TYPE_VENDOR|USB_RECIP_INTERFACE,
> > +					      1, 1, NULL, 0);
> > +			if (err < 0)
> > +				return err;
> > +			break;
> > +		case 1: /* PCM mode requested */
> > +			err = snd_usb_ctl_msg(dev, usb_sndctrlpipe(dev, 0), 0,
> > +					      USB_DIR_OUT|USB_TYPE_VENDOR|USB_RECIP_INTERFACE,
> > +					      0, 1, NULL, 0);
> > +			if (err > 0)
> > +				return err;
> > +			break;
> 
> maybe if (err < 0)?
Oops,right. Typo when I cleanup the patch...will resend as v2.

Jurgen
> 

  reply	other threads:[~2014-11-28 12:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28 12:31 [PATCH 0/2] usb: add native DSD support for Denon/Marantz Jurgen Kramer
2014-11-28 12:31 ` [PATCH 1/2] Add native DSD support for Denon/Marantz DACs Jurgen Kramer
2014-11-28 12:31 ` [PATCH 2/2] Signed-off-by: Jurgen Kramer <gtmkramer@xs4all.nl> Jurgen Kramer
2014-11-28 12:37   ` Alexander E. Patrakov
2014-11-28 12:40     ` Jurgen Kramer [this message]
2014-11-28 12:39   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417178436.2994.0.camel@xs4all.nl \
    --to=gtmkramer@xs4all.nl \
    --cc=alsa-devel@alsa-project.org \
    --cc=patrakov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).