From: Andrew Jackson <andrew.jackson@arm.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andrew Jackson <Andrew.Jackson@arm.com>
Subject: [PATCH] ASoC: adi: Add missing return statement.
Date: Wed, 31 Dec 2014 16:20:37 +0000 [thread overview]
Message-ID: <1420042837-3337-1-git-send-email-andrew.jackson@arm.com> (raw)
From: Andrew Jackson <Andrew.Jackson@arm.com>
The probe routine was disabling the clock even
if the system was configured successfully. Add
a return statement to leave clocks enabled.
Signed-off-by: Andrew Jackson <Andrew.Jackson@arm.com>
---
Spotted while reviewing clock preparation
sound/soc/adi/axi-i2s.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c
index 7752860..4c23381 100644
--- a/sound/soc/adi/axi-i2s.c
+++ b/sound/soc/adi/axi-i2s.c
@@ -240,6 +240,8 @@ static int axi_i2s_probe(struct platform_device *pdev)
if (ret)
goto err_clk_disable;
+ return 0;
+
err_clk_disable:
clk_disable_unprepare(i2s->clk);
return ret;
--
1.7.1
next reply other threads:[~2014-12-31 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-31 16:20 Andrew Jackson [this message]
2014-12-31 16:34 ` [PATCH] ASoC: adi: Add missing return statement Lars-Peter Clausen
2015-01-05 20:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420042837-3337-1-git-send-email-andrew.jackson@arm.com \
--to=andrew.jackson@arm.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).