* [PATCH 2/5] ASoC: fsl_asrc: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
@ 2015-01-07 15:44 ` Fabio Estevam
2015-01-07 15:44 ` [PATCH 3/5] ASoC: fsl_sai: " Fabio Estevam
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-01-07 15:44 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently the error message uses 'np->full_name' which leads to a very verbose
log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/fsl_asrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
index 5326ca7..c068494 100644
--- a/sound/soc/fsl/fsl_asrc.c
+++ b/sound/soc/fsl/fsl_asrc.c
@@ -836,7 +836,7 @@ static int fsl_asrc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+ dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
return irq;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 3/5] ASoC: fsl_sai: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
2015-01-07 15:44 ` [PATCH 2/5] ASoC: fsl_asrc: " Fabio Estevam
@ 2015-01-07 15:44 ` Fabio Estevam
2015-01-07 15:44 ` [PATCH 4/5] ASoC: fsl_esai: " Fabio Estevam
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-01-07 15:44 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently the error message uses 'np->full_name' which leads to a very verbose
log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/fsl_sai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
index 032d2d3..ec79c3d 100644
--- a/sound/soc/fsl/fsl_sai.c
+++ b/sound/soc/fsl/fsl_sai.c
@@ -612,7 +612,7 @@ static int fsl_sai_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+ dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
return irq;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 4/5] ASoC: fsl_esai: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
2015-01-07 15:44 ` [PATCH 2/5] ASoC: fsl_asrc: " Fabio Estevam
2015-01-07 15:44 ` [PATCH 3/5] ASoC: fsl_sai: " Fabio Estevam
@ 2015-01-07 15:44 ` Fabio Estevam
2015-01-07 15:44 ` [PATCH 5/5] ASoC: fsl_spdif: " Fabio Estevam
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-01-07 15:44 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently the error message uses 'np->full_name' which leads to a very verbose
log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/fsl_esai.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
index 1c08ab1..5c75971 100644
--- a/sound/soc/fsl/fsl_esai.c
+++ b/sound/soc/fsl/fsl_esai.c
@@ -774,7 +774,7 @@ static int fsl_esai_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+ dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
return irq;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 5/5] ASoC: fsl_spdif: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
` (2 preceding siblings ...)
2015-01-07 15:44 ` [PATCH 4/5] ASoC: fsl_esai: " Fabio Estevam
@ 2015-01-07 15:44 ` Fabio Estevam
2015-01-07 18:43 ` [PATCH 1/5] ASoC: fsl_ssi: " Nicolin Chen
2015-01-08 18:35 ` Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2015-01-07 15:44 UTC (permalink / raw)
To: broonie; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
From: Fabio Estevam <fabio.estevam@freescale.com>
Currently the error message uses 'np->full_name' which leads to a very verbose
log that contains the full path of the node.
We can have a concise log by using pdev->name instead.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/fsl/fsl_spdif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c
index 73da1f0..75870c0 100644
--- a/sound/soc/fsl/fsl_spdif.c
+++ b/sound/soc/fsl/fsl_spdif.c
@@ -1189,7 +1189,7 @@ static int fsl_spdif_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
+ dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
return irq;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH 1/5] ASoC: fsl_ssi: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
` (3 preceding siblings ...)
2015-01-07 15:44 ` [PATCH 5/5] ASoC: fsl_spdif: " Fabio Estevam
@ 2015-01-07 18:43 ` Nicolin Chen
2015-01-08 18:35 ` Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Nicolin Chen @ 2015-01-07 18:43 UTC (permalink / raw)
To: Fabio Estevam; +Cc: Fabio Estevam, alsa-devel, broonie
On Wed, Jan 07, 2015 at 01:44:32PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently the error message uses 'np->full_name' which leads to a very verbose
> log as:
>
> fsl-ssi-dai 202c000.ssi: no irq for node /soc/aips-bus@02000000/spba-bus@02000000/ssi@0202c000
>
> We can have a concise log by using pdev->name instead:
>
> fsl-ssi-dai 202c000.ssi: no irq for node 202c000.ssi
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
For all these 5 patches,
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Thank you
Nicolin
> ---
> sound/soc/fsl/fsl_ssi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index a65f17d..fa19507 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -1363,7 +1363,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
>
> ssi_private->irq = platform_get_irq(pdev, 0);
> if (!ssi_private->irq) {
> - dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
> + dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
> return -ENXIO;
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH 1/5] ASoC: fsl_ssi: Make error message concise
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
` (4 preceding siblings ...)
2015-01-07 18:43 ` [PATCH 1/5] ASoC: fsl_ssi: " Nicolin Chen
@ 2015-01-08 18:35 ` Mark Brown
5 siblings, 0 replies; 7+ messages in thread
From: Mark Brown @ 2015-01-08 18:35 UTC (permalink / raw)
To: Fabio Estevam; +Cc: nicoleotsuka, Fabio Estevam, alsa-devel
[-- Attachment #1.1: Type: text/plain, Size: 238 bytes --]
On Wed, Jan 07, 2015 at 01:44:32PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Currently the error message uses 'np->full_name' which leads to a very verbose
> log as:
Applied all, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread