From: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com
Subject: [PATCH 1/3] ucm: fix variable mixup
Date: Tue, 10 Feb 2015 22:42:32 +0200 [thread overview]
Message-ID: <1423600954-8751-2-git-send-email-tanu.kaskinen@linux.intel.com> (raw)
In-Reply-To: <1423600954-8751-1-git-send-email-tanu.kaskinen@linux.intel.com>
I assume the intention was to use cdev1 for PlaybackCTL and cdev2 for
CaptureCTL, but cdev1 was being used for both and cdev2 was not used
for anything.
---
src/ucm/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ucm/main.c b/src/ucm/main.c
index 182f174..3924aee 100644
--- a/src/ucm/main.c
+++ b/src/ucm/main.c
@@ -308,7 +308,7 @@ static int execute_sequence(snd_use_case_mgr_t *uc_mgr,
uc_error("cdev is not defined!");
return err;
}
- err = get_value3(&cdev1, "CaptureCTL",
+ err = get_value3(&cdev2, "CaptureCTL",
value_list1,
value_list2,
value_list3);
--
1.9.3
next prev parent reply other threads:[~2015-02-10 20:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 20:42 [PATCH 0/3] ucm: miscellaneous fixes Tanu Kaskinen
2015-02-10 20:42 ` Tanu Kaskinen [this message]
2015-02-11 11:43 ` [PATCH 1/3] ucm: fix variable mixup Takashi Iwai
2015-02-10 20:42 ` [PATCH 2/3] ucm: add a FIXME comment Tanu Kaskinen
2015-02-11 11:38 ` Takashi Iwai
2015-02-11 11:44 ` Tanu Kaskinen
2015-02-11 13:01 ` Takashi Iwai
2015-02-11 13:34 ` Tanu Kaskinen
2015-02-11 13:35 ` Takashi Iwai
2015-02-11 16:16 ` Liam Girdwood
2015-02-10 20:42 ` [PATCH 3/3] ucm: fix inappropriate use of const Tanu Kaskinen
2015-02-11 11:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423600954-8751-2-git-send-email-tanu.kaskinen@linux.intel.com \
--to=tanu.kaskinen@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox