Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Rorvick <chris@rorvick.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Chris Rorvick <chris@rorvick.com>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@gmail.com>
Subject: [PATCH 0/6] Cleanup reads/writes to Line 6 device memory
Date: Tue, 10 Feb 2015 23:03:11 -0600	[thread overview]
Message-ID: <1423630997-25464-1-git-send-email-chris@rorvick.com> (raw)

The primary fix here is to throttle the requests for status after a
read or write operation.  In some cases I was seeing more than 1000
before the device was ready with a response.

The remainder are smaller improvements related to the read/write logic.
All of this seems pretty straightforward with the possible exception of
changing the returned error from EINVAL to EIO.  The EINVAL seems wrong
to me but maybe not?

Regards,

Chris

Chris Rorvick (6):
  ALSA: line6: Improve line6_read/write_data() interfaces
  ALSA: line6: Add delay before reading status
  ALSA: line6: Return error if device not responding
  ALSA: line6: Return EIO if read/write not successful
  ALSA: line6: Use explicit type for serial number
  ALSA: line6: toneport: Use explicit type for firmware version

 sound/usb/line6/driver.c   | 51 +++++++++++++++++++++++++++++++++-------------
 sound/usb/line6/driver.h   | 10 ++++-----
 sound/usb/line6/pod.c      |  4 ++--
 sound/usb/line6/toneport.c |  4 ++--
 4 files changed, 46 insertions(+), 23 deletions(-)

-- 
2.1.0

             reply	other threads:[~2015-02-11  5:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-11  5:03 Chris Rorvick [this message]
2015-02-11  5:03 ` [PATCH 1/6] ALSA: line6: Improve line6_read/write_data() interfaces Chris Rorvick
2015-02-11  9:33   ` Takashi Iwai
2015-02-11 11:58     ` Chris Rorvick
2015-02-11  5:03 ` [PATCH 2/6] ALSA: line6: Add delay before reading status Chris Rorvick
2015-02-11  9:34   ` Takashi Iwai
2015-02-11  5:03 ` [PATCH 3/6] ALSA: line6: Return error if device not responding Chris Rorvick
2015-02-11  9:43   ` Takashi Iwai
2015-02-11  5:03 ` [PATCH 4/6] ALSA: line6: Return EIO if read/write not successful Chris Rorvick
2015-02-11  9:43   ` Takashi Iwai
2015-02-11  5:03 ` [PATCH 5/6] ALSA: line6: Use explicit type for serial number Chris Rorvick
2015-02-11  9:43   ` Takashi Iwai
2015-02-11  5:03 ` [PATCH 6/6] ALSA: line6: toneport: Use explicit type for firmware version Chris Rorvick
2015-02-11  9:43   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423630997-25464-1-git-send-email-chris@rorvick.com \
    --to=chris@rorvick.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefanha@gmail.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox