From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH 3/5] ASoC: smartq: Remove unnecessary snd_soc_dapm_disable_pin()
Date: Sun, 3 May 2015 19:27:08 +0200 [thread overview]
Message-ID: <1430674030-1388-3-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1430674030-1388-1-git-send-email-lars@metafoo.de>
The "Headphone Jack" widget is managed by the jack detection layer, there
is no need to manually disable.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/samsung/smartq_wm8987.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sound/soc/samsung/smartq_wm8987.c b/sound/soc/samsung/smartq_wm8987.c
index dfbe2db..c75f98d 100644
--- a/sound/soc/samsung/smartq_wm8987.c
+++ b/sound/soc/samsung/smartq_wm8987.c
@@ -147,9 +147,6 @@ static int smartq_wm8987_init(struct snd_soc_pcm_runtime *rtd)
snd_soc_dapm_nc_pin(dapm, "OUT3");
snd_soc_dapm_nc_pin(dapm, "ROUT1");
- /* set endpoints to default off mode */
- snd_soc_dapm_disable_pin(dapm, "Headphone Jack");
-
/* Headphone jack detection */
err = snd_soc_card_jack_new(rtd->card, "Headphone Jack",
SND_JACK_HEADPHONE, &smartq_jack,
--
1.8.0
next prev parent reply other threads:[~2015-05-03 17:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 17:27 [PATCH 1/5] ASoC: lowland: Use card DAPM context to access widgets Lars-Peter Clausen
2015-05-03 17:27 ` [PATCH 2/5] ASoC: smdk_wm8994: " Lars-Peter Clausen
2015-05-03 17:27 ` Lars-Peter Clausen [this message]
2015-05-03 17:27 ` [PATCH 4/5] ASoC: smartq: " Lars-Peter Clausen
2015-05-03 17:27 ` [PATCH 5/5] ASoC: speyside: Use snd_soc_codec_get_dapm() Lars-Peter Clausen
2015-05-04 8:07 ` Charles Keepax
2015-05-04 8:07 ` [PATCH 1/5] ASoC: lowland: Use card DAPM context to access widgets Charles Keepax
2015-05-04 11:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1430674030-1388-3-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).