From: Fabio Estevam <festevam@gmail.com>
To: broonie@kernel.org
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
Julia.Lawall@lip6.fr, alsa-devel@alsa-project.org
Subject: [PATCH 5/5] ASoC: max98095: Pass the IRQF_ONESHOT flag
Date: Tue, 12 May 2015 01:23:00 -0300 [thread overview]
Message-ID: <1431404580-17991-5-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1431404580-17991-1-git-send-email-festevam@gmail.com>
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
sound/soc/codecs/max98095.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c
index 66c7ca4..453a919 100644
--- a/sound/soc/codecs/max98095.c
+++ b/sound/soc/codecs/max98095.c
@@ -2300,8 +2300,8 @@ static int max98095_probe(struct snd_soc_codec *codec)
/* register an audio interrupt */
ret = request_threaded_irq(client->irq, NULL,
max98095_report_jack,
- IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
- "max98095", codec);
+ IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
+ IRQF_ONESHOT, "max98095", codec);
if (ret) {
dev_err(codec->dev, "Failed to request IRQ: %d\n", ret);
goto err_access;
--
1.9.1
next prev parent reply other threads:[~2015-05-12 4:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 4:22 [PATCH 1/5] ASoC: wm8996: Pass the IRQF_ONESHOT flag Fabio Estevam
2015-05-12 4:22 ` [PATCH 2/5] ASoC: wm5100: " Fabio Estevam
2015-05-12 4:22 ` [PATCH 3/5] ASoC: wm8994: " Fabio Estevam
2015-05-12 4:22 ` [PATCH 4/5] ASoC: twl6040: " Fabio Estevam
2015-05-12 18:47 ` Mark Brown
2015-05-12 4:23 ` Fabio Estevam [this message]
2015-05-12 18:48 ` [PATCH 1/5] ASoC: wm8996: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431404580-17991-5-git-send-email-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox