alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, patches.audio@intel.com,
	liam.r.girdwood@linux.intel.com,
	Vinod Koul <vinod.koul@intel.com>,
	broonie@kernel.org,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: [PATCH v2 4/8] ASoC: Intel: Remove the direct register reference from common ipc
Date: Tue, 19 May 2015 15:00:36 +0530	[thread overview]
Message-ID: <1432027840-18711-5-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1432027840-18711-1-git-send-email-vinod.koul@intel.com>

From: "Subhransu S. Prusty" <subhransu.s.prusty@intel.com>

Signed-off-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/common/sst-ipc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/sound/soc/intel/common/sst-ipc.c b/sound/soc/intel/common/sst-ipc.c
index 4b62a553823c..a7699f35a8d2 100644
--- a/sound/soc/intel/common/sst-ipc.c
+++ b/sound/soc/intel/common/sst-ipc.c
@@ -142,7 +142,6 @@ static void ipc_tx_msgs(struct kthread_work *work)
 		container_of(work, struct sst_generic_ipc, kwork);
 	struct ipc_message *msg;
 	unsigned long flags;
-	u64 ipcx;
 
 	spin_lock_irqsave(&ipc->dsp->spinlock, flags);
 
@@ -153,8 +152,8 @@ static void ipc_tx_msgs(struct kthread_work *work)
 
 	/* if the DSP is busy, we will TX messages after IRQ.
 	 * also postpone if we are in the middle of procesing completion irq*/
-	ipcx = sst_dsp_shim_read_unlocked(ipc->dsp, SST_IPCX);
-	if (ipcx & (SST_IPCX_BUSY | SST_IPCX_DONE)) {
+	if (ipc->ops.is_dsp_busy && ipc->ops.is_dsp_busy(ipc->dsp)) {
+		dev_dbg(ipc->dev, "ipc_tx_msgs dsp busy\n");
 		spin_unlock_irqrestore(&ipc->dsp->spinlock, flags);
 		return;
 	}
-- 
1.9.1

  parent reply	other threads:[~2015-05-19  9:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19  9:30 [PATCH v2 0/8] ASoC: Intel: refactor common SST IPC handling Vinod Koul
2015-05-19  9:30 ` [PATCH v2 1/8] ASoC: Intel: Create an ops to check for DSP busy Vinod Koul
2015-05-19  9:30 ` [PATCH v2 2/8] ASoC: Intel: Move the busy check to ops for Baytrail Vinod Koul
2015-05-19  9:30 ` [PATCH v2 3/8] ASoC: Intel: Move the busy check to ops for HSW Vinod Koul
2015-05-19  9:30 ` Vinod Koul [this message]
2015-05-19  9:30 ` [PATCH v2 5/8] ASoC: Intel: Allow to configure max size for mailbox data Vinod Koul
2015-05-19  9:30 ` [PATCH v2 6/8] ASoC: Intel: Initialize max mailbox size for baytrail Vinod Koul
2015-05-19  9:30 ` [PATCH v2 7/8] ASoC: Intel: Initialize max mailbox size for haswell Vinod Koul
2015-05-22 18:23   ` Mark Brown
2015-05-19  9:30 ` [PATCH v2 8/8] ASoC: Intel: Allocate for the mailbox with max size Vinod Koul
2015-05-19 10:42   ` Takashi Iwai
2015-05-19 11:07     ` Vinod Koul
2015-05-21 21:14 ` [PATCH v2 0/8] ASoC: Intel: refactor common SST IPC handling Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432027840-18711-5-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=subhransu.s.prusty@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).