alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jie Yang <yang.jie@intel.com>
To: broonie@kernel.org
Cc: alsa-devel@alsa-project.org, liam.r.girdwood@intel.com
Subject: [PATCH 0/4] new fix for broadwell module removing failed issue
Date: Sat, 30 May 2015 22:33:55 +0800	[thread overview]
Message-ID: <1432996439-8052-1-git-send-email-yang.jie@intel.com> (raw)

This patch series are based on broonie/sound.git for-next branch, commit
01a4d5083562fcdeab99d42b0873aabc5fcca018.

The broadwell platform driver had module removing failed issue, and the
two commits("ASoC: Intel: remove unused function hsw_pcm_free_modules()"
and "ASoC: Intel: fix broadwell module removing failed issue") workaround
it.

But at the same time, we shouldn't leave the device as suspended state
after module freed, it is not good to do runtime suspend at driver free
either, so the fix was workaround only and not good enough.

Here revert the old fix, and replace it with new unified procedure for
runtime modules freeing:
suspends firmware ==> frees runtime modules ==> unloads firmware.

With this new procedure, we remove the runtime modules at both runtime
suspend(D0->D3) and module(snd_soc_sst_haswell_pcm) removing, but make
sure we do it only once.

Jie Yang (4):
  Revert "ASoC: Intel: remove unused function hsw_pcm_free_modules()"
  Revert "ASoC: Intel: fix broadwell module removing failed issue"
  ASoC: Intel: check and clear runtime module pointer
  ASoC: Intel: handle haswell pcm suspend including runtime modules
    freeing

 sound/soc/intel/haswell/sst-haswell-pcm.c | 46 +++++++++++++++++++++++++------
 1 file changed, 37 insertions(+), 9 deletions(-)

-- 
1.9.1

             reply	other threads:[~2015-05-30 14:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-30 14:33 Jie Yang [this message]
2015-05-30 14:33 ` [PATCH 1/4] Revert "ASoC: Intel: remove unused function hsw_pcm_free_modules()" Jie Yang
2015-05-30 14:33 ` [PATCH 2/4] Revert "ASoC: Intel: fix broadwell module removing failed issue" Jie Yang
2015-05-30 14:33 ` [PATCH 3/4] ASoC: Intel: check and clear runtime module pointer Jie Yang
2015-05-30 14:33 ` [PATCH 4/4] ASoC: Intel: handle haswell pcm suspend including runtime modules freeing Jie Yang
2015-06-02 14:34 ` [PATCH 0/4] new fix for broadwell module removing failed issue Mark Brown
2015-06-03  2:40   ` Jie, Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1432996439-8052-1-git-send-email-yang.jie@intel.com \
    --to=yang.jie@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).