From: Vladimir Zapolskiy <vz@mleia.com>
To: Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <acourbot@nvidia.com>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
Axel Lin <axel.lin@ingics.com>, Takashi Iwai <tiwai@suse.de>,
patches@opensource.wolfsonmicro.com, linux-gpio@vger.kernel.org,
Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Subject: [PATCH 6/7] ASoC: wm8962: remove bitwise operations involving GPIO level value
Date: Tue, 2 Jun 2015 02:09:17 +0300 [thread overview]
Message-ID: <1433200158-6890-6-git-send-email-vz@mleia.com> (raw)
In-Reply-To: <1433200031-6748-1-git-send-email-vz@mleia.com>
The main intention of the change is to remove bitwise operations on
GPIO level value as a preceding change before updating gpiolib
callbacks to utilize bool type to represent GPIO level.
No functional change.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>
Cc: Axel Lin <axel.lin@ingics.com>
Cc: patches@opensource.wolfsonmicro.com
---
sound/soc/codecs/wm8962.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
index c5748fd..ad619e6 100644
--- a/sound/soc/codecs/wm8962.c
+++ b/sound/soc/codecs/wm8962.c
@@ -3341,9 +3341,13 @@ static void wm8962_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
{
struct wm8962_priv *wm8962 = gpio_to_wm8962(chip);
struct snd_soc_codec *codec = wm8962->codec;
+ unsigned int val = 0;
+
+ if (value)
+ val = 0x1 << WM8962_GP2_LVL_SHIFT;
snd_soc_update_bits(codec, WM8962_GPIO_BASE + offset,
- WM8962_GP2_LVL, !!value << WM8962_GP2_LVL_SHIFT);
+ WM8962_GP2_LVL, val);
}
static int wm8962_gpio_direction_out(struct gpio_chip *chip,
@@ -3351,10 +3355,11 @@ static int wm8962_gpio_direction_out(struct gpio_chip *chip,
{
struct wm8962_priv *wm8962 = gpio_to_wm8962(chip);
struct snd_soc_codec *codec = wm8962->codec;
- int ret, val;
+ unsigned int val = 0x1 << WM8962_GP2_FN_SHIFT;
+ int ret;
- /* Force function 1 (logic output) */
- val = (1 << WM8962_GP2_FN_SHIFT) | (value << WM8962_GP2_LVL_SHIFT);
+ if (value)
+ val |= 0x1 << WM8962_GP2_LVL_SHIFT;
ret = snd_soc_update_bits(codec, WM8962_GPIO_BASE + offset,
WM8962_GP2_FN_MASK | WM8962_GP2_LVL, val);
--
2.1.4
next prev parent reply other threads:[~2015-06-01 23:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 23:07 [PATCH 0/7] ASoC: remove bitwise operations on GPIO level value Vladimir Zapolskiy
2015-06-01 23:09 ` [PATCH 1/7] ASoC: rt5677: add GPIO helper macros Vladimir Zapolskiy
2015-06-02 5:23 ` Takashi Iwai
2015-06-01 23:09 ` [PATCH 2/7] ASoC: rt5677: clean up gpiolib callbacks Vladimir Zapolskiy
2015-06-02 19:38 ` Mark Brown
2015-06-02 20:39 ` Vladimir Zapolskiy
2015-06-02 20:50 ` Mark Brown
2015-06-02 21:54 ` Vladimir Zapolskiy
2015-06-03 11:38 ` Mark Brown
2015-06-01 23:09 ` [PATCH 3/7] ASoC: wm8903: generalize GPIO control register bits Vladimir Zapolskiy
2015-06-02 9:19 ` Charles Keepax
2015-06-04 8:30 ` Linus Walleij
2015-06-04 8:47 ` [alsa-devel] " Charles Keepax
2015-06-04 9:19 ` Mark Brown
2015-06-04 9:24 ` Charles Keepax
2015-06-04 10:34 ` Mark Brown
2015-06-01 23:09 ` [PATCH 4/7] ASoC: wm8903: simplify gpiolib callbacks Vladimir Zapolskiy
2015-06-02 8:38 ` Charles Keepax
2015-06-02 19:41 ` Mark Brown
2015-06-02 20:18 ` Vladimir Zapolskiy
2015-06-02 20:31 ` Mark Brown
2015-06-02 20:41 ` Vladimir Zapolskiy
2015-06-01 23:09 ` [PATCH 5/7] ASoC: wm5100: remove bitwise operations involving GPIO level value Vladimir Zapolskiy
2015-06-02 8:40 ` Charles Keepax
2015-06-02 19:45 ` Mark Brown
2015-06-02 20:23 ` Vladimir Zapolskiy
2015-06-02 20:36 ` Mark Brown
2015-06-02 20:58 ` Vladimir Zapolskiy
2015-06-03 10:50 ` Trent Piepho
2015-06-03 11:07 ` Mark Brown
2015-06-03 19:13 ` [alsa-devel] " Vladimir Zapolskiy
2015-06-03 21:51 ` Trent Piepho
2015-06-03 22:58 ` Vladimir Zapolskiy
2015-06-01 23:09 ` Vladimir Zapolskiy [this message]
2015-06-02 8:41 ` [PATCH 6/7] ASoC: wm8962: " Charles Keepax
2015-06-01 23:09 ` [PATCH 7/7] ASoC: wm8996: " Vladimir Zapolskiy
2015-06-02 8:43 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433200158-6890-6-git-send-email-vz@mleia.com \
--to=vz@mleia.com \
--cc=acourbot@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).