From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: broonie@kernel.org
Cc: patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com
Subject: [PATCH v8 4/4] regulator: arizona-ldo1: Do not control DVFS clocking from regulator
Date: Tue, 2 Jun 2015 11:53:36 +0100 [thread overview]
Message-ID: <1433242416-14958-4-git-send-email-rf@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1433242416-14958-1-git-send-email-rf@opensource.wolfsonmicro.com>
Using the driver for the internal regulator to also enable/disable
the codec internal clock frequency controller is an unexpected
side-effect for a regulator, and also means that the core clocks
won't be changed as expected if an external regulator is used to
power the codec.
The DVFS is now handled by the codec driver so can be removed from
the LDO1 driver.
Signed-off-by: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
---
drivers/regulator/arizona-ldo1.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c
index 9094163..5e947a8 100644
--- a/drivers/regulator/arizona-ldo1.c
+++ b/drivers/regulator/arizona-ldo1.c
@@ -78,11 +78,6 @@ static int arizona_ldo1_hc_set_voltage_sel(struct regulator_dev *rdev,
if (ret != 0)
return ret;
- ret = regmap_update_bits(regmap, ARIZONA_DYNAMIC_FREQUENCY_SCALING_1,
- ARIZONA_SUBSYS_MAX_FREQ, val);
- if (ret != 0)
- return ret;
-
if (val)
return 0;
--
1.7.2.5
next prev parent reply other threads:[~2015-06-02 10:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-02 10:53 [PATCH v8 1/4] ASoC: arizona: Export functions to control subsystem DVFS Richard Fitzgerald
2015-06-02 10:53 ` [PATCH v8 2/4] ASoC: wm_adsp: Move DVFS control into codec driver Richard Fitzgerald
2015-06-02 10:53 ` [PATCH v8 3/4] ASoC: arizona: Add DVFS handling for sample rate control Richard Fitzgerald
2015-06-02 10:53 ` Richard Fitzgerald [this message]
2015-06-02 20:07 ` [PATCH v8 1/4] ASoC: arizona: Export functions to control subsystem DVFS Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433242416-14958-4-git-send-email-rf@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).