From: Haojian Zhuang <haojian.zhuang@linaro.org>
To: Axel Lin <axel.lin@ingics.com>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: ASoC: 88pm860x: Question about pm860x_set_dai_sysclk implementation
Date: Mon, 29 Jun 2015 10:02:10 +0800 [thread overview]
Message-ID: <1435543330.1744.1.camel@linaro.org> (raw)
In-Reply-To: <1435503659.6929.1.camel@ingics.com>
On Sun, 2015-06-28 at 23:00 +0800, Axel Lin wrote:
> Hi Haojian,
> In sound/soc/codecs/88pm860x-codec.c (pm860x_set_dai_sysclk):
> When dir != PM860X_CLK_DIR_OUT, current code set
> pm860x->dir = PM860X_CLK_DIR_IN; and then return -EINVAL.
> This looks confusion.
> Since there is no comment for that, I'm wondering if the
> return -EINVAL is intentional or not.
>
> Regards,
> Axel
>
Hi Axel,
Since we didn't support slave mode in our solution, I just return
-EINVAL for PM860X_CLK_DIR_IN. I'm sorry to add the confused code.
Could you help to format a patch to add the comments?
Regards
Haojian
next prev parent reply other threads:[~2015-06-29 2:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 15:00 ASoC: 88pm860x: Question about pm860x_set_dai_sysclk implementation Axel Lin
2015-06-29 2:02 ` Haojian Zhuang [this message]
2015-06-29 2:27 ` Axel Lin
2015-06-29 2:49 ` Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435543330.1744.1.camel@linaro.org \
--to=haojian.zhuang@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox