From: Axel Lin <axel.lin@ingics.com>
To: Mark Brown <broonie@kernel.org>
Cc: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>,
patches@opensource.wolfsonmicro.com,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org
Subject: [PATCH 2/2] ASoC: wm8753: Drop wm8753_writeable function
Date: Sat, 01 Aug 2015 10:04:52 +0800 [thread overview]
Message-ID: <1438394692.6442.2.camel@ingics.com> (raw)
In-Reply-To: <1438394622.6442.1.camel@ingics.com>
When .max_register is set and .writeable_reg is not implement, registers
between 0 and .max_register are writeable. This is the same as current
implementation of wm8753_writeable(), so just drop implementation for
.writeable_reg callback.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
sound/soc/codecs/wm8753.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index b5e50ff..ab1b6b8 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -138,11 +138,6 @@ static bool wm8753_volatile(struct device *dev, unsigned int reg)
return reg == WM8753_RESET;
}
-static bool wm8753_writeable(struct device *dev, unsigned int reg)
-{
- return reg <= WM8753_ADCTL2;
-}
-
/* codec private data */
struct wm8753_priv {
struct regmap *regmap;
@@ -1510,7 +1505,6 @@ static const struct regmap_config wm8753_regmap = {
.val_bits = 9,
.max_register = WM8753_ADCTL2,
- .writeable_reg = wm8753_writeable,
.volatile_reg = wm8753_volatile,
.cache_type = REGCACHE_RBTREE,
--
2.1.0
next prev parent reply other threads:[~2015-08-01 2:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 2:03 [PATCH 1/2] ASoC: wm8731: Drop wm8731_writeable function Axel Lin
2015-08-01 2:04 ` Axel Lin [this message]
2015-08-05 12:30 ` Applied "ASoC: wm8753: Drop wm8753_writeable function" to the asoc tree Mark Brown
2015-08-06 16:24 ` [PATCH 2/2] ASoC: wm8753: Drop wm8753_writeable function Charles Keepax
2015-08-05 12:30 ` Applied "ASoC: wm8731: Drop wm8731_writeable function" to the asoc tree Mark Brown
2015-08-06 16:24 ` [PATCH 1/2] ASoC: wm8731: Drop wm8731_writeable function Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438394692.6442.2.camel@ingics.com \
--to=axel.lin@ingics.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=lgirdwood@gmail.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox