From: Liam Girdwood <liam.r.girdwood@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, mengdong.lin@linux.intel.com, "Koul,
Vinod" <vinod.koul@intel.com>,
mengdong.lin@intel.com, broonie@kernel.org,
subhransu.s.prusty@intel.com
Subject: Re: [PATCH] topology: Add API to set a vendor specific version number
Date: Wed, 23 Sep 2015 10:24:22 +0100 [thread overview]
Message-ID: <1443000262.6977.45.camel@loki> (raw)
In-Reply-To: <s5hio718qt2.wl-tiwai@suse.de>
+ Vinod
On Wed, 2015-09-23 at 10:48 +0200, Takashi Iwai wrote:
> On Wed, 16 Sep 2015 11:07:13 +0200,
> mengdong.lin@intel.com wrote:
> >
> > From: Mengdong Lin <mengdong.lin@intel.com>
> >
> > This vendor-specific version number is optional. It will be written to
> > the 'version' field of each block header of the binary toplogy data file.
> > The vendor driver can check this number for further processing in kernel.
> >
> > The topology ABI version number is still stored in the 'abi' field of
> > block headers.
> >
> > Signed-off-by: Mengdong Lin <mengdong.lin@intel.com>
> > Reviewed-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
>
> Thanks, applied now. But I have concern about topology ABI/API: have
> we stabilized it enough? That is, are there any missing patches in
> the current kernel and alsa-lib/utils git trees that may lead to any
> API/ABI incompatibilities?
There are a couple of patches that are ABI changes afaik for PCM
config/capabilities.
Mengdong, can you point us to your latest code for alsa-lib and kernel
with the ABI updates. We can then review the final changes.
Vinod, Subhransu, please shout if there is anything missing from the
final ABI updates in Mengdongs alsa-lib/kernel branches.
Thanks
Liam
>
>
> Takashi
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
next prev parent reply other threads:[~2015-09-23 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 9:07 [PATCH] topology: Add API to set a vendor specific version number mengdong.lin
2015-09-23 8:48 ` Takashi Iwai
2015-09-23 9:24 ` Liam Girdwood [this message]
2015-09-23 16:13 ` Lin, Mengdong
2015-09-23 16:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443000262.6977.45.camel@loki \
--to=liam.r.girdwood@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=mengdong.lin@intel.com \
--cc=mengdong.lin@linux.intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).