From: "Koul, Vinod" <vinod.koul@intel.com>
To: "broonie@kernel.org" <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tiwai@suse.de" <tiwai@suse.de>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
Patches Audio <patches.audio@intel.com>,
"Kp, Jeeja" <jeeja.kp@intel.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v3 6/8] ASoC: Intel: Skylake: Initialize and load DSP controls
Date: Tue, 6 Oct 2015 22:22:12 +0000 [thread overview]
Message-ID: <1444170130.25504.35.camel@intel.com> (raw)
In-Reply-To: <20151006162347.GA30592@sirena.org.uk>
On Tue, 2015-10-06 at 17:23 +0100, Mark Brown wrote:
> On Wed, Sep 23, 2015 at 08:33:22PM +0530, Vinod Koul wrote:
>
> > if (link_dev->link_prepared) {
> > - dev_dbg(dai->dev, "already stream is prepared - returning\n");
> > + dev_info(dai->dev, "already stream is prepared - returning\n");
> > return 0;
> > }
>
> Why is the severity of this being raised and if it does need raising why
> isn't it a warning or error?
On production systems, this helps to debug issues when something goes wrong and alsa
invokes prepare. But this might be false positive, usermode calling prepare for
usermode actions, that's why we cant say it is an error.
Thanks
--
~Vinod
next prev parent reply other threads:[~2015-10-06 22:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:03 [PATCH v3 0/8] Add DSP topology management for SKL Vinod Koul
2015-09-23 15:03 ` [PATCH v3 1/8] ASoC: Intel: Skylake: Add pipe and modules handlers Vinod Koul
2015-09-23 15:03 ` [PATCH v3 2/8] ASoC: Intel: Skylake: Add module configuration helpers Vinod Koul
2015-09-23 15:03 ` [PATCH v3 3/8] ASoC: Intel: Skylake: add DSP platform widget event handlers Vinod Koul
2015-09-23 15:03 ` [PATCH v3 4/8] ASoC: Intel: Skylake: Add FE and BE hw_params handling Vinod Koul
2015-09-23 15:03 ` [PATCH v3 5/8] ASoC: Intel: Skylake: Add topology core init and handlers Vinod Koul
2015-10-07 15:05 ` Applied "ASoC: Intel: Skylake: Add topology core init and handlers" to the asoc tree Mark Brown
2015-09-23 15:03 ` [PATCH v3 6/8] ASoC: Intel: Skylake: Initialize and load DSP controls Vinod Koul
2015-10-06 16:23 ` Mark Brown
2015-10-06 22:22 ` Koul, Vinod [this message]
2015-09-23 15:03 ` [PATCH v3 7/8] ASoC: Intel: Skylake: Add DSP support and enable it Vinod Koul
2015-09-23 15:03 ` [PATCH v3 8/8] ASoC: Intel: Skylake: Initialize NHLT table Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444170130.25504.35.camel@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).