alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: "Koul, Vinod" <vinod.koul@intel.com>
To: "liam.r.girdwood@linux.intel.com"
	<liam.r.girdwood@linux.intel.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"tiwai@suse.de" <tiwai@suse.de>,
	"Lin, Mengdong" <mengdong.lin@intel.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: topology: Reenable use from userspace
Date: Mon, 26 Oct 2015 03:54:32 +0000	[thread overview]
Message-ID: <1445831672.5321.18.camel@intel.com> (raw)
In-Reply-To: <1445830900-1752-1-git-send-email-broonie@kernel.org>

On Mon, 2015-10-26 at 12:41 +0900, Mark Brown wrote:
> We had inserted a #error into the topology UAPI code to ensure that the
> ABI was not adopted by userspace while final review and testing was
> ongoing.  Since we are now comfortable that the ABI is suitable for
> production remove the #error, future changes will include provision for
> backwards compatibility.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Acked-by: Vinod Koul <vinod.koul@intel.com>

I don't have any local patches on topology core, so am okay with this.

Liam, Mengdong do we have any more patches looking to be merged? I do see we have the
series we required in topic/topology, but is anything left out?

-- 
~Vinod

> ---
> 
> Are we OK with this?  Looking for some acks and reviews...
> 
>  include/uapi/sound/asoc.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/uapi/sound/asoc.h b/include/uapi/sound/asoc.h
> index 247c50b..51b8066 100644
> --- a/include/uapi/sound/asoc.h
> +++ b/include/uapi/sound/asoc.h
> @@ -18,12 +18,6 @@
>  #include <linux/types.h>
>  #include <sound/asound.h>
>  
> -#ifndef __KERNEL__
> -#error This API is an early revision and not enabled in the current
> -#error kernel release, it will be enabled in a future kernel version
> -#error with incompatible changes to what is here.
> -#endif
> -
>  /*
>   * Maximum number of channels topology kcontrol can represent.
>   */ 

  reply	other threads:[~2015-10-26  3:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-26  3:41 [PATCH] ASoC: topology: Reenable use from userspace Mark Brown
2015-10-26  3:54 ` Koul, Vinod [this message]
2015-10-26  7:30 ` Takashi Iwai
2015-10-27  0:22   ` Mark Brown
2015-10-31  2:54 ` Mark Brown
2015-11-02 10:47   ` Liam Girdwood
2016-10-11 10:28 ` Applied "ASoC: topology: Reenable use from userspace" to the asoc tree Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2016-10-06 14:30 [PATCH] ASoC: topology: Reenable use from userspace Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445831672.5321.18.camel@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mengdong.lin@intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).