From: "Koul, Vinod" <vinod.koul@intel.com>
To: "tiwai@suse.de" <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
Patches Audio <patches.audio@intel.com>,
"arnaud.pouliquen@st.com" <arnaud.pouliquen@st.com>,
"jsarha@ti.com" <jsarha@ti.com>,
"liam.r.girdwood@linux.intel.com"
<liam.r.girdwood@linux.intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"ykk@rock-chips.com" <ykk@rock-chips.com>,
"Prusty, Subhransu S" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v2 2/6] ASoC: hdac-hdmi: Add hdmi driver
Date: Mon, 26 Oct 2015 08:30:45 +0000 [thread overview]
Message-ID: <1445848243.5321.45.camel@intel.com> (raw)
In-Reply-To: <s5h1tci9jfd.wl-tiwai@suse.de>
On Mon, 2015-10-26 at 08:29 +0100, Takashi Iwai wrote:
> On Mon, 26 Oct 2015 02:07:49 +0100,
> Vinod Koul wrote:
> > +/*
> > + * Parse all nodes and store the cvt/pin nids in array
> > + * Add one time initialization for pin and cvt widgets
> > + */
> > +static int hdac_hdmi_parse_and_map_nid(struct hdac_ext_device *edev)
> > +{
> ....
> > + /*
> > + * Currently on board only 1 pin and 1 converter enabled.
> > + * So using fixed map for dai_id:pin:cvt
> > + */
> > + return hdac_hdmi_init_dai_map(edev, &hdmi->dai_map[0], hdmi->pin_nid[0],
> > + hdmi->cvt_nid[0], 0);
>
> Isn't this assumption too naive?
> And such a restriction has to be written more clearly in the
> changelog.
The intention here in this series is to have basic HDMI features enabled :) The
intention is to keep adding stuff to support multichannel, IEC, multiple outputs, SW
notification etc once basic driver is merged
Agreed we can add this to changelog. I can send updated rev, once I have other
comments
--
~Vinod
next prev parent reply other threads:[~2015-10-26 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 1:07 [PATCH v2 0/6] ASoC: Add HDA HDMI codec driver Vinod Koul
2015-10-26 1:07 ` [PATCH v2 1/6] ALSA: hdac: structure definition for ext_dma_params Vinod Koul
2015-10-26 1:07 ` [PATCH v2 2/6] ASoC: hdac-hdmi: Add hdmi driver Vinod Koul
2015-10-26 7:29 ` Takashi Iwai
2015-10-26 8:30 ` Koul, Vinod [this message]
2015-10-26 1:07 ` [PATCH v2 3/6] ASoC: hdac_hdmi: Add PM support for HDMI Vinod Koul
2015-10-26 1:07 ` [PATCH v2 4/6] ASoC: hdac_hdmi: Add hdac hdmi dai ops Vinod Koul
2015-10-26 1:07 ` [PATCH v2 5/6] ASoC: hdac_hdmi: Setup and start infoframe Vinod Koul
2015-10-26 1:07 ` [PATCH v2 6/6] ASoC: hdac_hdmi: Use i915 component framework for PM Vinod Koul
2015-11-21 14:00 ` Applied "ASoC: hdac_hdmi: Use i915 component framework for PM" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445848243.5321.45.camel@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux@arm.linux.org.uk \
--cc=patches.audio@intel.com \
--cc=subhransu.s.prusty@intel.com \
--cc=tiwai@suse.de \
--cc=ykk@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).