From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>,
Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 3/3] ASoC: core: Change power state before rechecking endpoint
Date: Mon, 23 Nov 2015 21:22:31 +0530 [thread overview]
Message-ID: <1448293951-32071-4-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1448293951-32071-1-git-send-email-vinod.koul@intel.com>
From: Jeeja KP <jeeja.kp@intel.com>
For DAPM resume, we should first change the power state of the
card and then recheck the endpoints. This ensures the dapm is
resumed first and then userspace can resume the streams.
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/soc-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 0a26ac0fb513..6dd704a6b76f 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -846,12 +846,12 @@ static void soc_resume_deferred(struct work_struct *work)
dev_dbg(card->dev, "ASoC: resume work completed\n");
- /* userspace can access us now we are back as we were before */
- snd_power_change_state(card->snd_card, SNDRV_CTL_POWER_D0);
-
/* Recheck all endpoints too, their state is affected by suspend */
dapm_mark_endpoints_dirty(card);
snd_soc_dapm_sync(&card->dapm);
+
+ /* userspace can access us now we are back as we were before */
+ snd_power_change_state(card->snd_card, SNDRV_CTL_POWER_D0);
}
/* powers up audio subsystem after a suspend */
--
1.9.1
next prev parent reply other threads:[~2015-11-23 15:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 15:52 [PATCH 0/3] ASoC: core: dapm more updates Vinod Koul
2015-11-23 15:52 ` [PATCH 1/3] ASoC: core: mark SND_SOC_BYTES_EXT as deprecated Vinod Koul
2015-11-25 12:59 ` Applied "ASoC: core: mark SND_SOC_BYTES_EXT as deprecated" to the asoc tree Mark Brown
2015-11-23 15:52 ` [PATCH 2/3] ASoC: core: add a dapm sink widget Vinod Koul
2015-11-24 9:48 ` Lars-Peter Clausen
2015-11-24 10:19 ` Vinod Koul
2015-11-25 12:51 ` Mark Brown
2015-11-25 12:59 ` Applied "ASoC: dapm: add a dapm sink widget" to the asoc tree Mark Brown
2015-11-23 15:52 ` Vinod Koul [this message]
2015-11-23 16:06 ` [PATCH 3/3] ASoC: core: Change power state before rechecking endpoint Lars-Peter Clausen
2015-11-23 17:28 ` Vinod Koul
2015-11-23 18:13 ` Lars-Peter Clausen
2015-11-24 10:17 ` Vinod Koul
2015-11-25 13:00 ` Applied "ASoC: core: Change power state before rechecking endpoint" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448293951-32071-4-git-send-email-vinod.koul@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).