From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>,
Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 2/7] ASoC: Intel: Skylake: Reconfigure HDA stream register in prepare/resume
Date: Mon, 23 Nov 2015 22:26:24 +0530 [thread overview]
Message-ID: <1448297789-6524-3-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1448297789-6524-1-git-send-email-vinod.koul@intel.com>
From: Jeeja KP <jeeja.kp@intel.com>
PCM prepare callbacks can be called multiple times. During S3
the stream registers will be reset when Controller is reset.
When stream is resumed, these stream registers needs to reconfigured.
This patch removes the check in prepare callback() if stream already
prepared, which will allow reconfiguring of stream registers and also
decouple stream when stream is resumed to route audio via DSP.
Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/skylake/skl-pcm.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c
index 4378bf452582..43944aff8dcb 100644
--- a/sound/soc/intel/skylake/skl-pcm.c
+++ b/sound/soc/intel/skylake/skl-pcm.c
@@ -182,10 +182,6 @@ static int skl_pcm_prepare(struct snd_pcm_substream *substream,
int err;
dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name);
- if (hdac_stream(stream)->prepared) {
- dev_dbg(dai->dev, "already stream is prepared - returning\n");
- return 0;
- }
format_val = skl_get_format(substream, dai);
dev_dbg(dai->dev, "stream_tag=%d formatvalue=%d\n",
@@ -343,6 +339,8 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
struct skl *skl = get_skl_ctx(dai->dev);
struct skl_sst *ctx = skl->skl_sst;
struct skl_module_cfg *mconfig;
+ struct hdac_ext_bus *ebus = get_bus_ctx(substream);
+ struct hdac_ext_stream *stream = get_hdac_ext_stream(substream);
int ret;
mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream);
@@ -350,15 +348,17 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
return -EIO;
switch (cmd) {
+ case SNDRV_PCM_TRIGGER_RESUME:
+ skl_pcm_prepare(substream, dai);
case SNDRV_PCM_TRIGGER_START:
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
- case SNDRV_PCM_TRIGGER_RESUME:
/*
* Start HOST DMA and Start FE Pipe.This is to make sure that
* there are no underrun/overrun in the case when the FE
* pipeline is started but there is a delay in starting the
* DMA channel on the host.
*/
+ snd_hdac_ext_stream_decouple(ebus, stream, true);
ret = skl_decoupled_trigger(substream, cmd);
if (ret < 0)
return ret;
@@ -378,6 +378,8 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
return ret;
ret = skl_decoupled_trigger(substream, cmd);
+ if (cmd == SNDRV_PCM_TRIGGER_SUSPEND)
+ snd_hdac_ext_stream_decouple(ebus, stream, false);
break;
default:
--
1.9.1
next prev parent reply other threads:[~2015-11-23 16:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 16:56 [PATCH 0/7] ASoC: Intel: Skylake: Fix suspend issues Vinod Koul
2015-11-23 16:56 ` [PATCH 1/7] ASoC: Intel: Skylake: Add Resume capability in PCM info Vinod Koul
2015-11-23 18:45 ` Takashi Iwai
2015-11-24 2:44 ` Vinod Koul
2015-11-24 6:07 ` Takashi Iwai
2015-11-26 8:56 ` Vinod Koul
2015-11-26 9:06 ` Takashi Iwai
2016-01-10 12:22 ` Applied "ASoC: Intel: Skylake: Add Resume capability in PCM info." to the asoc tree Mark Brown
2015-11-23 16:56 ` Vinod Koul [this message]
2015-11-25 17:57 ` Applied "ASoC: Intel: Skylake: Reconfigure HDA stream register in prepare/resume" " Mark Brown
2015-11-23 16:56 ` [PATCH 3/7] ASoC: Intel: Skylake: Fix to update bit depth for module params Vinod Koul
2015-11-25 17:57 ` Applied "ASoC: Intel: Skylake: Fix to update bit depth for module params" to the asoc tree Mark Brown
2015-11-23 16:56 ` [PATCH 4/7] ASoC: Intel: Skylake: Update pcm capability Vinod Koul
2015-11-25 17:57 ` Applied "ASoC: Intel: Skylake: Update pcm capability" to the asoc tree Mark Brown
2015-11-23 16:56 ` [PATCH 5/7] ASoC: Intel: Skylake: Poll CLDMA RUN bit when set Vinod Koul
2015-11-25 17:57 ` Applied "ASoC: Intel: Skylake: Poll CLDMA RUN bit when set" to the asoc tree Mark Brown
2015-11-23 16:56 ` [PATCH 6/7] ASoC: Intel: Skylake: Clear stream registers before setting up stream Vinod Koul
2015-11-23 16:56 ` [PATCH 7/7] ASoC: Intel: Skylake: Move up pipe mem free Vinod Koul
2015-11-25 17:57 ` Applied "ASoC: Intel: Skylake: Move up pipe mem free" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448297789-6524-3-git-send-email-vinod.koul@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).