From: Insu Yun <wuninsu@gmail.com>
To: perex@perex.cz, tiwai@suse.com, michael@gernoth.net,
lambert.quentin@gmail.com, pzubaj@marticonet.sk,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Cc: taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu,
changwoo@gatech.edu, Insu Yun <wuninsu@gmail.com>
Subject: [PATCH v2] emu10k1: correctly handling failed thread creation
Date: Fri, 29 Jan 2016 10:56:11 -0500 [thread overview]
Message-ID: <1454082971-12873-1-git-send-email-wuninsu@gmail.com> (raw)
Since kthread_create can be failed, it needs to check
whether error occurred and return error code.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
sound/pci/emu10k1/emu10k1_main.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c
index 28e2f8b..8914534 100644
--- a/sound/pci/emu10k1/emu10k1_main.c
+++ b/sound/pci/emu10k1/emu10k1_main.c
@@ -1141,6 +1141,14 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu)
emu->emu1010.firmware_thread =
kthread_create(emu1010_firmware_thread, emu,
"emu1010_firmware");
+ if (IS_ERR(emu->emu1010.firmware_thread)) {
+ err = PTR_ERR(emu->emu1010.firmware_thread);
+ emu->emu1010.firmware_thread = NULL;
+ dev_info(emu->card->dev,
+ "emu1010: Creating thread failed\n");
+ return err;
+ }
+
wake_up_process(emu->emu1010.firmware_thread);
}
--
1.9.1
next reply other threads:[~2016-01-29 15:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-29 15:56 Insu Yun [this message]
2016-01-29 16:31 ` [alsa-devel] [PATCH v2] emu10k1: correctly handling failed thread creation Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454082971-12873-1-git-send-email-wuninsu@gmail.com \
--to=wuninsu@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=changwoo@gatech.edu \
--cc=insu@gatech.edu \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@gernoth.net \
--cc=perex@perex.cz \
--cc=pzubaj@marticonet.sk \
--cc=taesoo@gatech.edu \
--cc=tiwai@suse.com \
--cc=yeongjin.jang@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).