From mboxrd@z Thu Jan 1 00:00:00 1970 From: pascal.huerst@gmail.com Subject: [PATCH] ASoC: sigmadsp: Fix missleading return value Date: Wed, 10 Feb 2016 15:59:28 +0100 Message-ID: <1455116368-26148-1-git-send-email-pascal.huerst@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by alsa0.perex.cz (Postfix) with ESMTP id 79AA6260673 for ; Wed, 10 Feb 2016 15:59:52 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id p63so32531350wmp.1 for ; Wed, 10 Feb 2016 06:59:52 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: lars@metafoo.de Cc: alsa-devel@alsa-project.org, broonie@kernel.org, Pascal Huerst , lgirdwood@gmail.com List-Id: alsa-devel@alsa-project.org From: Pascal Huerst Forwarding the return value of i2c_master_send, leads to errors later on, since i2c_master_send returns the number of bytes transmittet. Check for ret < 0 instead and return 0 otherwise. Signed-off-by: Pascal Huerst --- sound/soc/codecs/sigmadsp-i2c.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/sigmadsp-i2c.c b/sound/soc/codecs/sigmadsp-i2c.c index 21ca3a5..d374c18 100644 --- a/sound/soc/codecs/sigmadsp-i2c.c +++ b/sound/soc/codecs/sigmadsp-i2c.c @@ -31,7 +31,10 @@ static int sigmadsp_write_i2c(void *control_data, kfree(buf); - return ret; + if (ret < 0) + return ret; + + return 0; } static int sigmadsp_read_i2c(void *control_data, -- 2.4.3