[PATCH 1/2] ALSA: compress: Add SNDRV_PCM_STATE_PREPARED state explanation

[PATCH 1/2] ALSA: compress: Add SNDRV_PCM_STATE_PREPARED state explanation

[Vinod Koul]

Stream states were explained in the code comments but
SNDRV_PCM_STATE_PREPARED was missed so add it

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/core/compress_offload.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 7fac3cae8abd..51a8eb495f54 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -74,6 +74,9 @@ struct snd_compr_file {
  * SNDRV_PCM_STATE_SETUP: When stream has been initialized. This is done by
  *	calling SNDRV_COMPRESS_SET_PARAMS. running streams will come to this
  *	state at stop by calling SNDRV_COMPRESS_STOP, or at end of drain.
+ * SNDRV_PCM_STATE_PREPARED: When a stream has been written to (for
+ *	playback only). User after setting up stream writes the data buffer
+ *	before starting the stream.
  * SNDRV_PCM_STATE_RUNNING: When stream has been started and is
  *	decoding/encoding and rendering/capturing data.
  * SNDRV_PCM_STATE_DRAINING: When stream is draining current data. This is done
-- 
1.9.1

[PATCH 2/2] ALSA: compress: fix some typos

[Vinod Koul]

Found few typos while looking at code, so fix them

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/core/compress_offload.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
index 51a8eb495f54..c4b14b5f1b35 100644
--- a/sound/core/compress_offload.c
+++ b/sound/core/compress_offload.c
@@ -69,10 +69,10 @@ struct snd_compr_file {
 
 /*
  * a note on stream states used:
- * we use follwing states in the compressed core
+ * we use following states in the compressed core
  * SNDRV_PCM_STATE_OPEN: When stream has been opened.
  * SNDRV_PCM_STATE_SETUP: When stream has been initialized. This is done by
- *	calling SNDRV_COMPRESS_SET_PARAMS. running streams will come to this
+ *	calling SNDRV_COMPRESS_SET_PARAMS. Running streams will come to this
  *	state at stop by calling SNDRV_COMPRESS_STOP, or at end of drain.
  * SNDRV_PCM_STATE_PREPARED: When a stream has been written to (for
  *	playback only). User after setting up stream writes the data buffer
-- 
1.9.1

Re: [PATCH 1/2] ALSA: compress: Add SNDRV_PCM_STATE_PREPARED state explanation

[Takashi Iwai]

On Fri, 04 Mar 2016 15:55:29 +0100,
Vinod Koul wrote:
> 
> Stream states were explained in the code comments but
> SNDRV_PCM_STATE_PREPARED was missed so add it
> 
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>

Applied both patches.  Thanks.


Takashi

> ---
>  sound/core/compress_offload.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 7fac3cae8abd..51a8eb495f54 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -74,6 +74,9 @@ struct snd_compr_file {
>   * SNDRV_PCM_STATE_SETUP: When stream has been initialized. This is done by
>   *	calling SNDRV_COMPRESS_SET_PARAMS. running streams will come to this
>   *	state at stop by calling SNDRV_COMPRESS_STOP, or at end of drain.
> + * SNDRV_PCM_STATE_PREPARED: When a stream has been written to (for
> + *	playback only). User after setting up stream writes the data buffer
> + *	before starting the stream.
>   * SNDRV_PCM_STATE_RUNNING: When stream has been started and is
>   *	decoding/encoding and rendering/capturing data.
>   * SNDRV_PCM_STATE_DRAINING: When stream is draining current data. This is done
> -- 
> 1.9.1
>