Re: [PATCH v5 6/9] ASoC: hdmi-codec: Use HDMI notifications to add jack support

[Philipp Zabel <p.zabel@pengutronix.de>]

Hi Jyri,

Am Dienstag, den 08.03.2016, 00:31 +0200 schrieb Jyri Sarha:
> I don't think this patch was updated according to updated "video: rmk's 
> HDMI notification prototype":
> 
> On 03/02/16 16:49, Philipp Zabel wrote:
> > Use HDMI connection / disconnection notifications to update an ALSA
> > jack object. Also make a copy of the ELD block after every change.
> >
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >   include/sound/hdmi-codec.h    |  6 +++
> >   sound/soc/codecs/hdmi-codec.c | 85 +++++++++++++++++++++++++++++++++++++++----
> >   2 files changed, 83 insertions(+), 8 deletions(-)
> >
> > diff --git a/include/sound/hdmi-codec.h b/include/sound/hdmi-codec.h
> > index 15fe70f..8b6219d 100644
> > --- a/include/sound/hdmi-codec.h
> > +++ b/include/sound/hdmi-codec.h
> > @@ -99,6 +99,12 @@ struct hdmi_codec_pdata {
> >   	int max_i2s_channels;
> >   };
> >
> > +struct snd_soc_codec;
> > +struct snd_soc_jack;
> > +
> > +int hdmi_codec_set_jack_detect(struct snd_soc_codec *codec,
> > +			       struct snd_soc_jack *jack);
> > +
> >   #define HDMI_CODEC_DRV_NAME "hdmi-audio-codec"
> >
> >   #endif /* __HDMI_CODEC_H__ */
> > diff --git a/sound/soc/codecs/hdmi-codec.c b/sound/soc/codecs/hdmi-codec.c
> > index 687332d..7d5db11 100644
> > --- a/sound/soc/codecs/hdmi-codec.c
> > +++ b/sound/soc/codecs/hdmi-codec.c
> > @@ -12,9 +12,12 @@
> >    * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.	 See the GNU
> >    * General Public License for more details.
> >    */
> > +#include <linux/hdmi-not.h>
> 
> This should be hdmi-notifier.h. "select HDMI_NOTIFIERS" also needs to be 
> added to SND_SOC_HDMI_CODEC config option for compilation to succeed.

Yes, thank you for pointing that out. Will be fixed in v6.

regards
Philipp