* [PATCH] Show sequencer sound card numer/PID via aconnect
@ 2016-02-12 18:56 Martin Koegler
2016-02-13 12:30 ` Takashi Sakamoto
0 siblings, 1 reply; 5+ messages in thread
From: Martin Koegler @ 2016-02-12 18:56 UTC (permalink / raw)
To: alsa-devel; +Cc: Martin Koegler
From: Martin Koegler <martin.koegler@chello.at>
Signed-off-by: Martin Koegler <martin.koegler@chello.at>
---
seq/aconnect/aconnect.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/seq/aconnect/aconnect.c b/seq/aconnect/aconnect.c
index 8d6cebb..3508e1b 100644
--- a/seq/aconnect/aconnect.c
+++ b/seq/aconnect/aconnect.c
@@ -166,11 +166,19 @@ static void print_port(snd_seq_t *seq, snd_seq_client_info_t *cinfo,
snd_seq_port_info_t *pinfo, int count)
{
if (! count) {
- printf(_("client %d: '%s' [type=%s]\n"),
+ printf(_("client %d: '%s' [type=%s"),
snd_seq_client_info_get_client(cinfo),
snd_seq_client_info_get_name(cinfo),
(snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT ?
_("user") : _("kernel")));
+ int owner = snd_seq_client_info_get_owner(cinfo);
+ if (owner != -1) {
+ if (snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT)
+ printf(",pid=%d", owner);
+ else
+ printf(",card=%d", owner);
+ }
+ printf("]\n");
}
printf(" %3d '%-16s'\n",
snd_seq_port_info_get_port(pinfo),
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Show sequencer sound card numer/PID via aconnect
2016-02-12 18:56 Martin Koegler
@ 2016-02-13 12:30 ` Takashi Sakamoto
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Sakamoto @ 2016-02-13 12:30 UTC (permalink / raw)
To: Martin Koegler, alsa-devel
Hi,
On Feb 13 2016 03:56, Martin Koegler wrote:
> From: Martin Koegler <martin.koegler@chello.at>
>
> Signed-off-by: Martin Koegler <martin.koegler@chello.at>
The idea to print owner PID or card number is itself better to me, while
I think you should add some comments to describe your intension about
this patch, at least, for the other developers or users. Would you
please re-post this patch with your comments again?
Regards
Takashi Sakamoto
> ---
> seq/aconnect/aconnect.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/seq/aconnect/aconnect.c b/seq/aconnect/aconnect.c
> index 8d6cebb..3508e1b 100644
> --- a/seq/aconnect/aconnect.c
> +++ b/seq/aconnect/aconnect.c
> @@ -166,11 +166,19 @@ static void print_port(snd_seq_t *seq, snd_seq_client_info_t *cinfo,
> snd_seq_port_info_t *pinfo, int count)
> {
> if (! count) {
> - printf(_("client %d: '%s' [type=%s]\n"),
> + printf(_("client %d: '%s' [type=%s"),
> snd_seq_client_info_get_client(cinfo),
> snd_seq_client_info_get_name(cinfo),
> (snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT ?
> _("user") : _("kernel")));
> + int owner = snd_seq_client_info_get_owner(cinfo);
> + if (owner != -1) {
> + if (snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT)
> + printf(",pid=%d", owner);
> + else
> + printf(",card=%d", owner);
> + }
> + printf("]\n");
> }
> printf(" %3d '%-16s'\n",
> snd_seq_port_info_get_port(pinfo),
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Show sequencer sound card numer/PID via aconnect
2016-02-13 13:42 [PATCH] Provide sequencer sound card number / PID via alsa-lib Martin Koegler
@ 2016-02-13 13:42 ` Martin Koegler
0 siblings, 0 replies; 5+ messages in thread
From: Martin Koegler @ 2016-02-13 13:42 UTC (permalink / raw)
To: alsa-devel; +Cc: Martin Koegler
From: Martin Koegler <martin.koegler@chello.at>
rawmidi devices expose the card number via IOCTLs, which allows to
find the corresponding device in sysfs.
The sequencer provides no identifing data. Chromium works around this
issue by scanning rawmidi as well as sequencer devices and matching
them by using assumtions, how the kernel register sequencer devices.
This patch adds support for displaying the sound card number/PID to
aconnect.
Signed-off-by: Martin Koegler <martin.koegler@chello.at>
---
seq/aconnect/aconnect.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/seq/aconnect/aconnect.c b/seq/aconnect/aconnect.c
index 8d6cebb..3508e1b 100644
--- a/seq/aconnect/aconnect.c
+++ b/seq/aconnect/aconnect.c
@@ -166,11 +166,19 @@ static void print_port(snd_seq_t *seq, snd_seq_client_info_t *cinfo,
snd_seq_port_info_t *pinfo, int count)
{
if (! count) {
- printf(_("client %d: '%s' [type=%s]\n"),
+ printf(_("client %d: '%s' [type=%s"),
snd_seq_client_info_get_client(cinfo),
snd_seq_client_info_get_name(cinfo),
(snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT ?
_("user") : _("kernel")));
+ int owner = snd_seq_client_info_get_owner(cinfo);
+ if (owner != -1) {
+ if (snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT)
+ printf(",pid=%d", owner);
+ else
+ printf(",card=%d", owner);
+ }
+ printf("]\n");
}
printf(" %3d '%-16s'\n",
snd_seq_port_info_get_port(pinfo),
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] Show sequencer sound card numer/PID via aconnect
@ 2016-03-08 22:06 Martin Koegler
2016-03-09 8:16 ` Takashi Iwai
0 siblings, 1 reply; 5+ messages in thread
From: Martin Koegler @ 2016-03-08 22:06 UTC (permalink / raw)
To: alsa-devel; +Cc: Martin Koegler
From: Martin Koegler <martin.koegler@chello.at>
rawmidi devices expose the card number via IOCTLs, which allows to
find the corresponding device in sysfs.
The sequencer provides no identifing data. Chromium works around this
issue by scanning rawmidi as well as sequencer devices and matching
them by using assumtions, how the kernel register sequencer devices.
This patch adds support for displaying the sound card number/PID to
aconnect.
Signed-off-by: Martin Koegler <martin.koegler@chello.at>
---
configure.ac | 9 +++++++++
seq/aconnect/aconnect.c | 17 ++++++++++++++++-
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index bdb133c..9e48190 100644
--- a/configure.ac
+++ b/configure.ac
@@ -41,6 +41,15 @@ AC_CHECK_HEADERS([alsa/topology.h], [have_topology="yes"], [have_topology="no"],
AC_CHECK_HEADERS([samplerate.h], [have_samplerate="yes"], [have_samplerate="no"],
[#include <samplerate.h>])
+AC_CHECK_LIB([asound], [snd_seq_client_info_get_card], [HAVE_SEQ_CLIENT_INFO_GET_CARD="yes"])
+if test "$HAVE_SEQ_CLIENT_INFO_GET_CARD" = "yes" ; then
+ AC_DEFINE([HAVE_SEQ_CLIENT_INFO_GET_CARD], 1, [alsa-lib supports snd_seq_client_info_get_card])
+fi
+AC_CHECK_LIB([asound], [snd_seq_client_info_get_pid], [HAVE_SEQ_CLIENT_INFO_GET_PID="yes"])
+if test "$HAVE_SEQ_CLIENT_INFO_GET_PID" = "yes" ; then
+ AC_DEFINE([HAVE_SEQ_CLIENT_INFO_GET_PID], 1, [alsa-lib supports snd_seq_client_info_get_pid])
+fi
+
AM_CONDITIONAL(HAVE_PCM, test "$have_pcm" = "yes")
AM_CONDITIONAL(HAVE_MIXER, test "$have_mixer" = "yes")
AM_CONDITIONAL(HAVE_RAWMIDI, test "$have_rawmidi" = "yes")
diff --git a/seq/aconnect/aconnect.c b/seq/aconnect/aconnect.c
index 8d6cebb..85a7770 100644
--- a/seq/aconnect/aconnect.c
+++ b/seq/aconnect/aconnect.c
@@ -166,11 +166,26 @@ static void print_port(snd_seq_t *seq, snd_seq_client_info_t *cinfo,
snd_seq_port_info_t *pinfo, int count)
{
if (! count) {
- printf(_("client %d: '%s' [type=%s]\n"),
+ int card = -1, pid = -1;
+
+ printf(_("client %d: '%s' [type=%s"),
snd_seq_client_info_get_client(cinfo),
snd_seq_client_info_get_name(cinfo),
(snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT ?
_("user") : _("kernel")));
+
+#ifdef HAVE_SEQ_CLIENT_INFO_GET_CARD
+ card = snd_seq_client_info_get_card(cinfo);
+#endif
+ if (card != -1)
+ printf(",card=%d", card);
+
+#ifdef HAVE_SEQ_CLIENT_INFO_GET_PID
+ pid = snd_seq_client_info_get_pid(cinfo);
+#endif
+ if (pid != -1)
+ printf(",pid=%d", pid);
+ printf("]\n");
}
printf(" %3d '%-16s'\n",
snd_seq_port_info_get_port(pinfo),
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Show sequencer sound card numer/PID via aconnect
2016-03-08 22:06 [PATCH] Show sequencer sound card numer/PID via aconnect Martin Koegler
@ 2016-03-09 8:16 ` Takashi Iwai
0 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2016-03-09 8:16 UTC (permalink / raw)
To: Martin Koegler; +Cc: alsa-devel
On Tue, 08 Mar 2016 23:06:47 +0100,
Martin Koegler wrote:
>
> From: Martin Koegler <martin.koegler@chello.at>
>
> rawmidi devices expose the card number via IOCTLs, which allows to
> find the corresponding device in sysfs.
>
> The sequencer provides no identifing data. Chromium works around this
> issue by scanning rawmidi as well as sequencer devices and matching
> them by using assumtions, how the kernel register sequencer devices.
>
> This patch adds support for displaying the sound card number/PID to
> aconnect.
>
> Signed-off-by: Martin Koegler <martin.koegler@chello.at>
Applied, thanks.
Takashi
> ---
> configure.ac | 9 +++++++++
> seq/aconnect/aconnect.c | 17 ++++++++++++++++-
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index bdb133c..9e48190 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -41,6 +41,15 @@ AC_CHECK_HEADERS([alsa/topology.h], [have_topology="yes"], [have_topology="no"],
> AC_CHECK_HEADERS([samplerate.h], [have_samplerate="yes"], [have_samplerate="no"],
> [#include <samplerate.h>])
>
> +AC_CHECK_LIB([asound], [snd_seq_client_info_get_card], [HAVE_SEQ_CLIENT_INFO_GET_CARD="yes"])
> +if test "$HAVE_SEQ_CLIENT_INFO_GET_CARD" = "yes" ; then
> + AC_DEFINE([HAVE_SEQ_CLIENT_INFO_GET_CARD], 1, [alsa-lib supports snd_seq_client_info_get_card])
> +fi
> +AC_CHECK_LIB([asound], [snd_seq_client_info_get_pid], [HAVE_SEQ_CLIENT_INFO_GET_PID="yes"])
> +if test "$HAVE_SEQ_CLIENT_INFO_GET_PID" = "yes" ; then
> + AC_DEFINE([HAVE_SEQ_CLIENT_INFO_GET_PID], 1, [alsa-lib supports snd_seq_client_info_get_pid])
> +fi
> +
> AM_CONDITIONAL(HAVE_PCM, test "$have_pcm" = "yes")
> AM_CONDITIONAL(HAVE_MIXER, test "$have_mixer" = "yes")
> AM_CONDITIONAL(HAVE_RAWMIDI, test "$have_rawmidi" = "yes")
> diff --git a/seq/aconnect/aconnect.c b/seq/aconnect/aconnect.c
> index 8d6cebb..85a7770 100644
> --- a/seq/aconnect/aconnect.c
> +++ b/seq/aconnect/aconnect.c
> @@ -166,11 +166,26 @@ static void print_port(snd_seq_t *seq, snd_seq_client_info_t *cinfo,
> snd_seq_port_info_t *pinfo, int count)
> {
> if (! count) {
> - printf(_("client %d: '%s' [type=%s]\n"),
> + int card = -1, pid = -1;
> +
> + printf(_("client %d: '%s' [type=%s"),
> snd_seq_client_info_get_client(cinfo),
> snd_seq_client_info_get_name(cinfo),
> (snd_seq_client_info_get_type(cinfo) == SND_SEQ_USER_CLIENT ?
> _("user") : _("kernel")));
> +
> +#ifdef HAVE_SEQ_CLIENT_INFO_GET_CARD
> + card = snd_seq_client_info_get_card(cinfo);
> +#endif
> + if (card != -1)
> + printf(",card=%d", card);
> +
> +#ifdef HAVE_SEQ_CLIENT_INFO_GET_PID
> + pid = snd_seq_client_info_get_pid(cinfo);
> +#endif
> + if (pid != -1)
> + printf(",pid=%d", pid);
> + printf("]\n");
> }
> printf(" %3d '%-16s'\n",
> snd_seq_port_info_get_port(pinfo),
> --
> 2.1.4
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-03-09 8:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 22:06 [PATCH] Show sequencer sound card numer/PID via aconnect Martin Koegler
2016-03-09 8:16 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2016-02-13 13:42 [PATCH] Provide sequencer sound card number / PID via alsa-lib Martin Koegler
2016-02-13 13:42 ` [PATCH] Show sequencer sound card numer/PID via aconnect Martin Koegler
2016-02-12 18:56 Martin Koegler
2016-02-13 12:30 ` Takashi Sakamoto
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).