From: PC Liao <pc.liao@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
srv_heupstream <srv_heupstream@mediatek.com>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Koro Chen (陳思翰)" <koro.chen@mediatek.com>
Subject: Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date: Wed, 20 Apr 2016 17:39:50 +0800 [thread overview]
Message-ID: <1461145190.3774.5.camel@mtksdaap41> (raw)
In-Reply-To: <20160420082917.GH3217@sirena.org.uk>
Hi Mark,
On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote:
> On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote:
>
> > +Optional properties:
> > +- capture-dai: audio codec dai on capture path
> > + <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> > + <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)
>
> I sugggested changing this to use a subnode but you've ignored my
> suggestion...
Sorry.... It's my mistake.
You mean that using a subnode.
This is my example:
codec-capture {
sound-dai = <&rt5650 1>;
};
Does this is your suggestion?
Thanks!
next prev parent reply other threads:[~2016-04-20 9:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 6:40 [PATCH 0/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 6:40 ` [PATCH 1/2 v6] ASoC: core: export snd_soc_get_dai_name PC Liao
2016-04-20 6:40 ` [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao
2016-04-20 8:29 ` Mark Brown
2016-04-20 9:39 ` PC Liao [this message]
2016-04-20 16:11 ` Mark Brown
2016-04-20 13:30 ` Matthias Brugger
2016-04-20 16:27 ` PC Liao
2016-04-21 9:22 ` Matthias Brugger
2016-04-21 9:38 ` PC Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461145190.3774.5.camel@mtksdaap41 \
--to=pc.liao@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=koro.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).