alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>,
	Mousumi Jana <mousumix.jana@intel.com>
Subject: [PATCH 2/5] ASoC: Intel: Skylake: Fix memory leak during init instance
Date: Thu, 28 Apr 2016 18:45:26 +0530	[thread overview]
Message-ID: <1461849329-20364-3-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1461849329-20364-1-git-send-email-vinod.koul@intel.com>

From: Mousumi Jana <mousumix.jana@intel.com>

param_data variable is allocated during set module format of init
instance is not getting freed and hence can cause a memory leak.
So free it up.

Signed-off-by: Mousumi Jana <mousumix.jana@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl-messages.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-messages.c b/sound/soc/intel/skylake/skl-messages.c
index e3d149c68bbf..226db84ba20f 100644
--- a/sound/soc/intel/skylake/skl-messages.c
+++ b/sound/soc/intel/skylake/skl-messages.c
@@ -864,7 +864,7 @@ int skl_init_module(struct skl_sst *ctx,
 		return ret;
 	}
 	mconfig->m_state = SKL_MODULE_INIT_DONE;
-
+	kfree(param_data);
 	return ret;
 }
 
-- 
1.9.1

  parent reply	other threads:[~2016-04-28 13:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-28 13:15 [PATCH 0/5] ASoC: Intel: Skylake: Wov optimizations Vinod Koul
2016-04-28 13:15 ` [PATCH 1/5] ASoC: Intel: Skylake: Fix the NULL pointer exception in dsp_clean up Vinod Koul
2016-05-02 11:03   ` Applied "ASoC: Intel: Skylake: Fix the NULL pointer exception in dsp_clean up" to the asoc tree Mark Brown
2016-04-28 13:15 ` Vinod Koul [this message]
2016-05-02 11:03   ` Applied "ASoC: Intel: Skylake: Fix memory leak during init instance" " Mark Brown
2016-04-28 13:15 ` [PATCH 3/5] ASoC: Intel: Skylake: Prevent sending Set DMA Control IPC if the widget is "On" Vinod Koul
2016-05-02 11:03   ` Applied "ASoC: Intel: Skylake: Prevent sending Set DMA Control IPC if the widget is "On"" to the asoc tree Mark Brown
2016-04-28 13:15 ` [PATCH 4/5] ASoC: Intel: Skylake: Suspend PCMs when marked as active suspend Vinod Koul
2016-05-02 11:03   ` Applied "ASoC: Intel: Skylake: Suspend PCMs when marked as active suspend" to the asoc tree Mark Brown
2016-04-28 13:15 ` [PATCH 5/5] ASoC: Intel: Boards: remove ignore_suspend for WoV streams Vinod Koul
2016-05-02 11:03   ` Applied "ASoC: Intel: Boards: remove ignore_suspend for WoV streams" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1461849329-20364-3-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mousumix.jana@intel.com \
    --cc=patches.audio@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).