* [PATCH] infoleak fix1 in timer
@ 2016-05-03 20:44 Kangjie Lu
2016-05-08 9:38 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Kangjie Lu @ 2016-05-03 20:44 UTC (permalink / raw)
To: perex; +Cc: tiwai, linux-kernel, alsa-devel, taesoo, insu, Kangjie Lu
The stack object “tread” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
sound/core/timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 6469bed..964f5eb 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1739,6 +1739,7 @@ static int snd_timer_user_params(struct file *file,
if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
if (tu->tread) {
struct snd_timer_tread tread;
+ memset(&tread, 0, sizeof(tread));
tread.event = SNDRV_TIMER_EVENT_EARLY;
tread.tstamp.tv_sec = 0;
tread.tstamp.tv_nsec = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] infoleak fix1 in timer
2016-05-03 20:44 [PATCH] infoleak fix1 in timer Kangjie Lu
@ 2016-05-08 9:38 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2016-05-08 9:38 UTC (permalink / raw)
To: Kangjie Lu; +Cc: perex, alsa-devel, insu, Kangjie Lu, taesoo, linux-kernel
On Tue, 03 May 2016 22:44:07 +0200,
Kangjie Lu wrote:
>
> The stack object “tread” has a total size of 32 bytes. Its field
> “event” and “val” both contain 4 bytes padding. These 8 bytes
> padding bytes are sent to user without being initialized.
>
> Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Thanks, I applied now all three patches. But I rephrased the subjects
to more meaningful ones. Better to give a bit more informative
subject line at the next time.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-08 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-03 20:44 [PATCH] infoleak fix1 in timer Kangjie Lu
2016-05-08 9:38 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).