From: Kangjie Lu <kangjielu@gmail.com>
To: perex@perex.cz
Cc: tiwai@suse.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, taesoo@gatech.edu, insu@gatech.edu,
Kangjie Lu <kjlu@gatech.edu>
Subject: [PATCH] infoleak fix2 in timer
Date: Tue, 3 May 2016 16:44:20 -0400 [thread overview]
Message-ID: <1462308260-6219-1-git-send-email-kjlu@gatech.edu> (raw)
The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
---
sound/core/timer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/core/timer.c b/sound/core/timer.c
index 964f5eb..e98fa5f 100644
--- a/sound/core/timer.c
+++ b/sound/core/timer.c
@@ -1225,6 +1225,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri,
tu->tstamp = *tstamp;
if ((tu->filter & (1 << event)) == 0 || !tu->tread)
return;
+ memset(&r1, 0, sizeof(r1));
r1.event = event;
r1.tstamp = *tstamp;
r1.val = resolution;
--
1.9.1
reply other threads:[~2016-05-03 20:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462308260-6219-1-git-send-email-kjlu@gatech.edu \
--to=kangjielu@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=insu@gatech.edu \
--cc=kjlu@gatech.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=taesoo@gatech.edu \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).