From mboxrd@z Thu Jan 1 00:00:00 1970 From: Garlic Tseng Subject: Re: [alsa-devel] [PATCH 1/7] ASoC: mediatek: Refine mt8173 driver and change config option Date: Sat, 7 May 2016 02:33:56 +0800 Message-ID: <1462559636.11805.6.camel@mtksdaap41> References: <1461934848-60011-1-git-send-email-garlic.tseng@mediatek.com> <1461934848-60011-2-git-send-email-garlic.tseng@mediatek.com> <20160504164306.GA6292@sirena.org.uk> <1462416342.25179.36.camel@mtksdaap41> <572B0511.80701@gmail.com> <1462444772.2873.70.camel@mtksdaap41> <20160506122046.GR6292@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160506122046.GR6292@sirena.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Mark Brown Cc: Matthias Brugger , alsa-devel@alsa-project.org, ir.lian@mediatek.com, srv_heupstream@mediatek.com, tiwai@suse.de, linux-kernel@vger.kernel.org, koro.chen@mediatek.com, linux-mediatek@lists.infradead.org, PC.Liao@mediatek.com, linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org On Fri, 2016-05-06 at 13:20 +0100, Mark Brown wrote: > On Thu, May 05, 2016 at 06:39:32PM +0800, Garlic Tseng wrote: > > > As mentioned above, the difference of the ASoCs between the two chips > > are too large that we have a hard time sharing the driver code. > > The things you're describing all sound like scaling differences rather > than fundamental changes. I'd expect to see at least some shared code > here, we don't want to be just duplicating the entire driver every time > there's a new hardware revision. Oh ok, I'll do it in the next version. Thanks for comment.