alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
	broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>,
	Shreyas NC <shreyas.nc@intel.com>
Subject: [PATCH 3/7] ASoC: Intel: Skylake: Strip manifest for Skylake platform
Date: Mon, 30 May 2016 17:42:57 +0530	[thread overview]
Message-ID: <1464610381-19416-4-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1464610381-19416-1-git-send-email-vinod.koul@intel.com>

Future firmware updates may comes with extended manifest so invoke
skl_dsp_strip_extended_manifest() to check and strip

Signed-off-by: Shreyas NC <shreyas.nc@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/intel/skylake/skl-sst.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
index 13ec8d53b526..be2c42b815b7 100644
--- a/sound/soc/intel/skylake/skl-sst.c
+++ b/sound/soc/intel/skylake/skl-sst.c
@@ -72,6 +72,7 @@ static int skl_load_base_firmware(struct sst_dsp *ctx)
 {
 	int ret = 0, i;
 	struct skl_sst *skl = ctx->thread_context;
+	struct firmware stripped_fw;
 	u32 reg;
 
 	skl->boot_complete = false;
@@ -86,6 +87,12 @@ static int skl_load_base_firmware(struct sst_dsp *ctx)
 		}
 	}
 
+	/* check for extended manifest */
+	stripped_fw.data = ctx->fw->data;
+	stripped_fw.size = ctx->fw->size;
+
+	skl_dsp_strip_extended_manifest(&stripped_fw);
+
 	ret = skl_dsp_boot(ctx);
 	if (ret < 0) {
 		dev_err(ctx->dev, "Boot dsp core failed ret: %d", ret);
@@ -119,7 +126,7 @@ static int skl_load_base_firmware(struct sst_dsp *ctx)
 		goto transfer_firmware_failed;
 	}
 
-	ret = skl_transfer_firmware(ctx, ctx->fw->data, ctx->fw->size);
+	ret = skl_transfer_firmware(ctx, stripped_fw.data, stripped_fw.size);
 	if (ret < 0) {
 		dev_err(ctx->dev, "Transfer firmware failed%d\n", ret);
 		goto transfer_firmware_failed;
-- 
1.9.1

  parent reply	other threads:[~2016-05-30 12:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30 12:12 [PATCH 0/7] ASoC: Intel: Skylake: Manifest parsing support Vinod Koul
2016-05-30 12:12 ` [PATCH 1/7] ASoC: Intel: Skylake: Add strip extended manifest utility Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Add strip extended manifest utility" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 2/7] ASoC: Intel: Skylake: Don't use local pointer for firmware Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Don't use local pointer for firmware" to the asoc tree Mark Brown
2016-05-30 12:12 ` Vinod Koul [this message]
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Strip manifest for Skylake platform" " Mark Brown
2016-05-30 12:12 ` [PATCH 4/7] ASoC: Intel: Skylake: Strip manifest for Broxton platform Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Strip manifest for Broxton platform" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 5/7] ASoC: Intel: Skylake: Add DSP firmware manifest parsing Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Add DSP firmware manifest parsing" to the asoc tree Mark Brown
2016-05-30 12:13 ` [PATCH 6/7] ASoC: Intel: Skylake: Find uuids for Skylake Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Find uuids for Skylake" to the asoc tree Mark Brown
2016-05-30 12:13 ` [PATCH 7/7] ASoC: Intel: Skylake: Find uuids for Broxton Vinod Koul
2016-05-30 17:39   ` Applied "ASoC: Intel: Skylake: Find uuids for Broxton" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464610381-19416-4-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=patches.audio@intel.com \
    --cc=shreyas.nc@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).