From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
broonie@kernel.org, Vinod Koul <vinod.koul@intel.com>
Subject: [PATCH 6/7] ASoC: Intel: Skylake: Find uuids for Skylake
Date: Mon, 30 May 2016 17:43:00 +0530 [thread overview]
Message-ID: <1464610381-19416-7-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1464610381-19416-1-git-send-email-vinod.koul@intel.com>
SKylake uses different offset in manifest for parsing module
table. So invoke common parsing utility from skylake using
skylake offset.
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
sound/soc/intel/skylake/skl-sst.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/sound/soc/intel/skylake/skl-sst.c b/sound/soc/intel/skylake/skl-sst.c
index be2c42b815b7..6021fa6ed80d 100644
--- a/sound/soc/intel/skylake/skl-sst.c
+++ b/sound/soc/intel/skylake/skl-sst.c
@@ -68,6 +68,8 @@ static int skl_transfer_firmware(struct sst_dsp *ctx,
return ret;
}
+#define SKL_ADSP_FW_BIN_HDR_OFFSET 0x284
+
static int skl_load_base_firmware(struct sst_dsp *ctx)
{
int ret = 0, i;
@@ -85,6 +87,16 @@ static int skl_load_base_firmware(struct sst_dsp *ctx)
skl_dsp_disable_core(ctx);
return -EIO;
}
+
+ }
+
+ ret = snd_skl_parse_uuids(ctx, SKL_ADSP_FW_BIN_HDR_OFFSET);
+ if (ret < 0) {
+ dev_err(ctx->dev,
+ "UUID parsing err: %d\n", ret);
+ release_firmware(ctx->fw);
+ skl_dsp_disable_core(ctx);
+ return ret;
}
/* check for extended manifest */
@@ -416,6 +428,7 @@ int skl_sst_dsp_init(struct device *dev, void __iomem *mmio_base, int irq,
skl->dev = dev;
skl_dev.thread_context = skl;
+ INIT_LIST_HEAD(&skl->uuid_list);
skl->dsp = skl_dsp_ctx_init(dev, &skl_dev, irq);
if (!skl->dsp) {
@@ -459,6 +472,7 @@ EXPORT_SYMBOL_GPL(skl_sst_dsp_init);
void skl_sst_dsp_cleanup(struct device *dev, struct skl_sst *ctx)
{
skl_clear_module_table(ctx->dsp);
+ skl_freeup_uuid_list(ctx);
skl_ipc_free(&ctx->ipc);
ctx->dsp->ops->free(ctx->dsp);
if (ctx->boot_complete) {
--
1.9.1
next prev parent reply other threads:[~2016-05-30 12:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 12:12 [PATCH 0/7] ASoC: Intel: Skylake: Manifest parsing support Vinod Koul
2016-05-30 12:12 ` [PATCH 1/7] ASoC: Intel: Skylake: Add strip extended manifest utility Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Add strip extended manifest utility" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 2/7] ASoC: Intel: Skylake: Don't use local pointer for firmware Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Don't use local pointer for firmware" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 3/7] ASoC: Intel: Skylake: Strip manifest for Skylake platform Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Strip manifest for Skylake platform" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 4/7] ASoC: Intel: Skylake: Strip manifest for Broxton platform Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Strip manifest for Broxton platform" to the asoc tree Mark Brown
2016-05-30 12:12 ` [PATCH 5/7] ASoC: Intel: Skylake: Add DSP firmware manifest parsing Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Add DSP firmware manifest parsing" to the asoc tree Mark Brown
2016-05-30 12:13 ` Vinod Koul [this message]
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Find uuids for Skylake" " Mark Brown
2016-05-30 12:13 ` [PATCH 7/7] ASoC: Intel: Skylake: Find uuids for Broxton Vinod Koul
2016-05-30 17:39 ` Applied "ASoC: Intel: Skylake: Find uuids for Broxton" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464610381-19416-7-git-send-email-vinod.koul@intel.com \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).