* [PATCH] ASoC: rt5645: disable soft volume control
@ 2016-07-05 5:23 Bard Liao
2016-07-05 8:34 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Bard Liao @ 2016-07-05 5:23 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: oder_chiou, jack.yu, alsa-devel, lars, koro.chen, PC.Liao,
Bard Liao, flove
With soft volume control function, rt5645/rt5650 will start with 0dB
volume and take a little time to adjust volume to given value. And it
will cause a bad user experience. This patch disable it.
Signed-off-by: Bard Liao <bardliao@realtek.com>
---
sound/soc/codecs/rt5645.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 97bf96e..c969f48 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -63,6 +63,7 @@ static const struct reg_sequence init_list[] = {
{RT5645_PR_BASE + 0x20, 0x611f},
{RT5645_PR_BASE + 0x21, 0x4040},
{RT5645_PR_BASE + 0x23, 0x0004},
+ {RT5645_PR_BASE + 0x00, 0x0a2a},
{RT5645_ASRC_4, 0x0120},
};
--
1.8.1.1.439.g50a6b54
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: rt5645: disable soft volume control
2016-07-05 5:23 [PATCH] ASoC: rt5645: disable soft volume control Bard Liao
@ 2016-07-05 8:34 ` Mark Brown
2016-07-05 8:44 ` Bard Liao
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2016-07-05 8:34 UTC (permalink / raw)
To: Bard Liao
Cc: oder_chiou, jack.yu, alsa-devel, lars, lgirdwood, koro.chen,
PC.Liao, flove
[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]
On Tue, Jul 05, 2016 at 01:23:55PM +0800, Bard Liao wrote:
> With soft volume control function, rt5645/rt5650 will start with 0dB
> volume and take a little time to adjust volume to given value. And it
> will cause a bad user experience. This patch disable it.
This seems like something that it'd be better to give users control over
- some users will be annoyed by a soft ramp but there will be others who
welcome it.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rt5645: disable soft volume control
2016-07-05 8:34 ` Mark Brown
@ 2016-07-05 8:44 ` Bard Liao
0 siblings, 0 replies; 3+ messages in thread
From: Bard Liao @ 2016-07-05 8:44 UTC (permalink / raw)
To: Mark Brown
Cc: Oder Chiou, Jack Yu, alsa-devel@alsa-project.org, lars@metafoo.de,
lgirdwood@gmail.com, koro.chen@mediatek.com, PC.Liao@mediatek.com,
Flove
> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Tuesday, July 05, 2016 4:34 PM
> To: Bard Liao
> Cc: lgirdwood@gmail.com; alsa-devel@alsa-project.org;
> lars@metafoo.de; Flove; Oder Chiou; Jack Yu; koro.chen@mediatek.com;
> PC.Liao@mediatek.com
> Subject: Re: [PATCH] ASoC: rt5645: disable soft volume control
>
> On Tue, Jul 05, 2016 at 01:23:55PM +0800, Bard Liao wrote:
> > With soft volume control function, rt5645/rt5650 will start with 0dB
> > volume and take a little time to adjust volume to given value. And it
> > will cause a bad user experience. This patch disable it.
>
> This seems like something that it'd be better to give users control over
> - some users will be annoyed by a soft ramp but there will be others who
> welcome it.
Good idea. I will do it.
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-05 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-05 5:23 [PATCH] ASoC: rt5645: disable soft volume control Bard Liao
2016-07-05 8:34 ` Mark Brown
2016-07-05 8:44 ` Bard Liao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).