From: Nicolin Chen <nicoleotsuka@gmail.com>
To: broonie@kernel.org
Cc: lgirdwood@gmail.com, brian.austin@cirrus.com,
Paul.Handrigan@cirrus.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org
Subject: [PATCH 2/2] ASoC: cs53l30: Fix bit shift issue of TDM mode
Date: Tue, 19 Jul 2016 15:36:14 -0700 [thread overview]
Message-ID: <1468967774-18621-2-git-send-email-nicoleotsuka@gmail.com> (raw)
In-Reply-To: <1468967774-18621-1-git-send-email-nicoleotsuka@gmail.com>
The TDM mode using PCM format now has two-bit right shift due to the
format configuration in the driver. According to Figure 4-13 in the
CS53L30 datasheet, using ASP_SCLK_INV = 0 and SHIFT_LEFT = 1 should
be the correct combination to create one-bit right shift for the DSP
type A format.
Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com>
---
sound/soc/codecs/cs53l30.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index fd5502e..2c0d9c4 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -592,8 +592,12 @@ static int cs53l30_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
aspctl1 |= CS53L30_ASP_TDM_PDN;
break;
case SND_SOC_DAIFMT_DSP_A:
- /* Clear TDM_PDN and SHIFT_LEFT, invert SCLK */
- aspcfg |= CS53L30_ASP_SCLK_INV;
+ /*
+ * Clear TDM_PDN to turn on TDM mode; Use ASP_SCLK_INV = 0
+ * with SHIFT_LEFT = 1 combination as Figure 4-13 shows in
+ * the CS53L30 datasheet
+ */
+ aspctl1 |= CS53L30_SHIFT_LEFT;
break;
default:
return -EINVAL;
--
2.1.4
next prev parent reply other threads:[~2016-07-19 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 22:36 [PATCH 1/2] ASoC: cs53l30: Fix a bug for TDM slot location validation Nicolin Chen
2016-07-19 22:36 ` Nicolin Chen [this message]
2016-07-21 11:08 ` Applied "ASoC: cs53l30: Fix bit shift issue of TDM mode" to the asoc tree Mark Brown
2016-07-21 11:08 ` Applied "ASoC: cs53l30: Fix a bug for TDM slot location validation" " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468967774-18621-2-git-send-email-nicoleotsuka@gmail.com \
--to=nicoleotsuka@gmail.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).